Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(buildkite): exclude files/folders that are not tested in Buildkite #2368

Merged
merged 2 commits into from
Jan 28, 2025

Conversation

v1v
Copy link
Member

@v1v v1v commented Jan 23, 2025

What does this PR do?

Skip files that are not used in Buildkite

Why is it important?

Run faster builds and avoid waste of CI cycles.

I decided to support the whole .github folder since some other files, such as CODEOWNERS or .dependabot.yml, and the rest are not used by Buildkite.

The same for the docs, IIUC, that's not tested in BK itself but a BK docs pipeline owned by the docs team

@v1v v1v self-assigned this Jan 23, 2025
@v1v v1v requested a review from a team as a code owner January 23, 2025 11:29
.buildkite/pull-requests.json Outdated Show resolved Hide resolved
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

cc @v1v

@mrodm
Copy link
Contributor

mrodm commented Jan 23, 2025

One doubt here @v1v, in this repository, the elastic-package Buildkite pipeline is a required check status in Pull Requests to be able to merge it. The same configuration is applied in other repositories like integrations or package-spec (in their corresponding pipelines).

What would happen for those Pull Requests that do not trigger the given build?

IIUC, if this PR is merged, all the following PRs updating just those files should be merged bypassing branch protections. Is that the expected approach?

EDIT:
Could it be that the status check for that pipeline is set to "success" in those cases?
Checking the configuration, the set_commit_status is set to true, so maybe that helps here.

@v1v
Copy link
Member Author

v1v commented Jan 27, 2025

That's a good question. I created elastic/beats#42437 and it passed the GH check:

image

So the GH check should be the name of the BK pipeline rather than a subset of the steps.

Is that the case?

@mrodm
Copy link
Contributor

mrodm commented Jan 28, 2025

That's a good question. I created elastic/beats#42437 and it passed the GH check:

image So the GH check should be the name of the BK pipeline rather than a subset of the steps.

Is that the case?

Perfect! it marks the pipeline status as successful 👍 In our case, we just have one status check per pipeline, so that's good.

Thanks for checking this out!

@v1v v1v merged commit e412e98 into elastic:main Jan 28, 2025
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants