Check compose status only with compose provider #2356
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When creating clients from profile, check the status of the compose project only when using the compose stack provider.
jsoriano
force-pushed
the
avoid-compose-status-other-providers
branch
from
14acdd1 to
a501b62
Compare
💚 Build Succeeded
cc @jsoriano |
|
test serverless |
|
Triggered serverless pipeline: https://buildkite.com/elastic/elastic-package-test-serverless/builds/275 |
mrodm
approved these changes
Jan 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When creating clients from profile, check the status of the compose project only when using the compose stack provider. This prevents elastic-package trying to find local containers when using other providers.
I am not adding explicit support for other providers because they would need the client itself to check the status, what would lead to infinite recursion.