ci(mergify): upgrade configuration to current format #2237
Conversation
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
💚 Build Succeeded
History
|
| - check-success=buildkite/elastic-package | ||
| merge_method: squash | ||
|
|
||
| pull_request_rules: | ||
| - name: automatic approval for Dependabot pull requests |
There was a problem hiding this comment.
Well, is the condition of this rule needed now?
There was a problem hiding this comment.
Do you mean the automatic approval for Dependabot pull requests pull request rule?
That rule does not have any condition.
The other pull request rule (automatic merge of bot 🤖) has no conditions (empty array), so probably it could be removed the conditions entry. I could push a commit deleting that entry.
There was a problem hiding this comment.
Do you mean the
automatic approval for Dependabot pull requestspull request rule?
That rule does not have any condition.
Yes, I refer to this one.
It has this condition, right?
conditions:
- author~=^dependabot(|-preview)\[bot\]$
Is it needed? Or why was it removed from the other rule and not from here? 🤔
There was a problem hiding this comment.
Ok! I didn't see it because Github didn't show it (it was collapsed) 😅
What I understand is that from the other rule it is removed because it uses as an action to enqueue the PR (and it uses the conditions defined in the queue). In this rule, there is no action to enqueue the PR. This is just to approve the PR.
What I'm wondering now if it is required to add as part of the queue_conditions this #approved-reviews-by one (docs), but it's true that before there was no such a rule:
queue_conditions:
- check-success=buildkite/elastic-package
- check-success=CLA
- base=main
- author~=^dependabot(|-preview)\[bot\]$
- "#approved-reviews-by >= 1"There was a problem hiding this comment.
What I understand is that from the other rule it is removed because it uses as an action to enqueue the PR (and it uses the conditions defined in the queue). In this rule, there is no action to enqueue the PR. This is just to approve the PR.
Ah ok, this is what I was not understanding.
What I'm wondering now if it is required to add as part of the queue_conditions this #approved-reviews-by one (docs)
I guess we are checking this with the branch protection rules?
There was a problem hiding this comment.
I guess we are checking this with the branch protection rules?
Yes, I think so, that rule is there.
No more deprecated fields are being used in your Mergify configuration, this pull request will be closed.