Fix: don't skip _dev/build directories #212
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
|
ycombinator
reviewed
Jan 6, 2021
| @@ -218,7 +218,6 @@ An example event for `status` looks as following: | |||
| | apache.status.cpu.load | CPU Load. | scaled_float | | |||
| | apache.status.cpu.system | System cpu. | scaled_float | | |||
| | apache.status.cpu.user | CPU user load. | scaled_float | | |||
| | apache.status.hostname | Apache hostname. | keyword | | |||
There was a problem hiding this comment.
Is this change intentional? At first glance it seems unrelated to this PR but maybe I'm wrong.
There was a problem hiding this comment.
It's related, because it's the first time the README has been rendered correctly :)
ycombinator
approved these changes
Jan 6, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes the issue with skip
_dev/builddirectories. I spotted this one while investigating other issues and noticed warnings that README files are static and not generated from templates.