Accept newer revisions when waiting for policies to be assigned #1289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When tearing down tests, we try to reassign the previous policy. If it was modified and we also expect the revision to be the same, it will never succeed, it will wait till timeout.
💚 Build Succeeded
cc @jsoriano |
mrodm
reviewed
Jun 1, 2023
mrodm
approved these changes
Jun 1, 2023
jsoriano
deleted the
accept-newer-revisions-when-waiting-for-policy-assigned
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tearing down tests, we try to reassign the previous policy. If it was modified and we also expect the revision to be the same, it will never succeed, it will wait till timeout.