Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove mapping to trigger field #1245

Merged
merged 5 commits into from
May 2, 2023
Merged

remove mapping to trigger field #1245

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
f2de9e7
remove mapping to trigger field
gsantoro Apr 28, 2023
dc9b36b
removed dynamic templates containing trigger field
gsantoro Apr 28, 2023
260ed7a
address comments from pr
gsantoro Apr 28, 2023
15e8451
Update internal/builder/testdata/existing.yml
gsantoro May 2, 2023
6de904b
Update internal/builder/testdata/expected.existing.mappings.yml
gsantoro May 2, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 0 additions & 4 deletions internal/builder/_static/ecs_mappings.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -447,7 +447,3 @@ mappings:
mapping:
type: nested
path_match: '*.macho.sections'
- trigger_to_nested:
mapping:
type: nested
match: trigger
8 changes: 5 additions & 3 deletions internal/builder/testdata/existing.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,9 @@ elasticsearch:
example:
type: short
dynamic_templates:
- to_nested:
path: trigger
- forwarded_ip_to_ip:
mapping:
type: nested
type: ip
match: forwarded_ip
match_mapping_type: string

7 changes: 4 additions & 3 deletions internal/builder/testdata/expected.existing.mappings.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,11 @@ elasticsearch:
example:
type: short
dynamic_templates:
- to_nested:
path: trigger
- forwarded_ip_to_ip:
mapping:
type: nested
type: ip
match: forwarded_ip
match_mapping_type: string
- _embedded_ecs-example_template:
mapping:
type: short
Expand Down