Add component backstage #1237
Merged
Add component backstage #1237
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mrodm
force-pushed
the
add_component_backstage
branch
from
ef81708 to
e78efde
Compare
alexsapran
approved these changes
Apr 25, 2023
| spec: | ||
| type: tool | ||
| owner: group:ingest-fp # Find your group in https://backstage.elastic.dev/catalog?filters%5Bkind%5D=group | ||
| system: platform-ingest # Find your group in https://backstage.elastic.dev/catalog?filters%5Bkind%5D=system |
There was a problem hiding this comment.
This is not yet shown in the list of services in backstage, otherwise LGTM
There was a problem hiding this comment.
This platform-ingest already appears in the list 👍
💚 Build Succeeded
cc @mrodm |
alexsapran
approved these changes
Apr 25, 2023
|
I think we can now merge, given that the domain/system is sorted in backstage |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates the Component resource for elastic-package to be used by Backstage