Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: SERVICE_LOGS points to agent path #112

Merged
merged 1 commit into from
Sep 21, 2020
Merged

Fix: SERVICE_LOGS points to agent path #112

merged 1 commit into from
Sep 21, 2020

Conversation

mtojek
Copy link
Contributor

@mtojek mtojek commented Sep 21, 2020 •
edited
Loading

This PR fixes issue with invalid path defined in config.

Found in: #111

Zrzut ekranu 2020-09-21 o 11 47 18

@mtojek mtojek requested a review from ycombinator September 21, 2020 09:45
@mtojek mtojek self-assigned this Sep 21, 2020
ycombinator
ycombinator approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@ycombinator ycombinator left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Sorry I didn’t catch this in the original review 🤦.

@mtojek
Copy link
Contributor Author

mtojek commented Sep 21, 2020

I'm the one that apologizes for introducing this... I'll wait for green status and merge it.

@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #112 opened]

  • Start Time: 2020-09-21T09:45:30.033+0000

  • Duration: 9 min 20 sec

@mtojek mtojek merged commit 7a811f6 into elastic:master Sep 21, 2020
@mtojek mtojek mentioned this pull request Sep 28, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ycombinator ycombinator ycombinator approved these changes

Assignees

@mtojek mtojek

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mtojek @elasticmachine @ycombinator