Skip error uninstalling system package (#1315)

Skip errors uninstalling system package in the system and asset
testrunners (tear down process). For other packages failing during
this uninstallation process, a warning message is logged.

internal/testrunner/runners/asset/runner.go

@@ -51,7 +51,7 @@ func (r runner) CanRunPerDataStream() bool {
 }
 
 // Run runs the asset loading tests
-func (r runner) Run(options testrunner.TestOptions) ([]testrunner.TestResult, error) {
+func (r *runner) Run(options testrunner.TestOptions) ([]testrunner.TestResult, error) {
 	r.testFolder = options.TestFolder
 	r.packageRootPath = options.PackageRootPath
 
@@ -82,7 +82,11 @@ func (r *runner) run() ([]testrunner.TestResult, error) {
 	if err != nil {
 		return result.WithError(errors.Wrap(err, "could not create kibana client"))
 	}
-	packageInstaller, err := installer.CreateForManifest(kibanaClient, r.packageRootPath)
+	packageInstaller, err := installer.NewForPackage(installer.Options{
+		Kibana:         kibanaClient,
+		RootPath:       r.packageRootPath,
+		SkipValidation: true,
+	})
 	if err != nil {
 		return result.WithError(errors.Wrap(err, "can't create the package installer"))
 	}
@@ -92,9 +96,18 @@ func (r *runner) run() ([]testrunner.TestResult, error) {
 	}
 
 	r.removePackageHandler = func() error {
+		pkgManifest, err := packages.ReadPackageManifestFromPackageRoot(r.packageRootPath)
+		if err != nil {
+			return fmt.Errorf("reading package manifest failed: %w", err)
+		}
+
 		logger.Debug("removing package...")
-		if err := packageInstaller.Uninstall(); err != nil {
-			return errors.Wrap(err, "error cleaning up package")
+		err = packageInstaller.Uninstall()
+
+		// by default system package is part of an agent policy and it cannot be uninstalled
+		// https://github.com/elastic/elastic-package/blob/5f65dc29811c57454bc7142aaf73725b6d4dc8e6/internal/stack/_static/kibana.yml.tmpl#L62
+		if err != nil && pkgManifest.Name != "system" {
+			logger.Warnf("failed to uninstall package %q: %s", pkgManifest.Name, err.Error())
 		}
 		return nil
 	}

internal/testrunner/runners/system/runner.go

@@ -496,8 +496,13 @@ func (r *runner) runTest(config *testConfig, ctxt servicedeployer.ServiceContext
 	}
 	r.deletePackageHandler = func() error {
 		err := installer.Uninstall()
-		if err != nil {
-			return fmt.Errorf("failed to uninstall package: %v", err)
+
+		// by default system package is part of an agent policy and it cannot be uninstalled
+		// https://github.com/elastic/elastic-package/blob/5f65dc29811c57454bc7142aaf73725b6d4dc8e6/internal/stack/_static/kibana.yml.tmpl#L62
+		if err != nil && pkgManifest.Name != "system" {
+			// logging the error as a warning and not returning it since there could be other reasons that could make fail this process
+			// for instance being defined a test agent policy where this package is used for debugging purposes
+			logger.Warnf("failed to uninstall package %q: %s", pkgManifest.Name, err.Error())
 		}
 		return nil
 	}

internal/testrunner/testrunner.go

@@ -274,7 +274,7 @@ func Run(testType TestType, options TestOptions) ([]TestResult, error) {
 		return nil, errors.Wrap(err, "could not complete test run")
 	}
 	if tdErr != nil {
-		return results, errors.Wrap(err, "could not teardown test runner")
+		return results, errors.Wrap(tdErr, "could not teardown test runner")
 	}
 	return results, nil
 }

scripts/links_table.yml

@@ -1,2 +1,3 @@
 links:
   elastic-main: "https://www.elastic.co/guide"
+  getting-started-observability: "https://www.elastic.co/guide/en/welcome-to-elastic/current/getting-started-observability.html"

test/packages/parallel/system/_dev/build/build.yml

@@ -0,0 +1,3 @@
+dependencies:
+  ecs:
+    reference: [email protected]