feat: add domain padding #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- add margin to domain - allow unconstrained padded domains - create specific y domain type - deprecate yScaleToDataExtent
Codecov Report
@@ Coverage Diff @@
## master #707 +/- ##
==========================================
- Coverage 74.80% 74.48% -0.32%
==========================================
Files 265 282 +17
Lines 8541 8890 +349
Branches 1714 1754 +40
==========================================
+ Hits 6389 6622 +233
- Misses 2099 2211 +112
- Partials 53 57 +4
Continue to review full report at Codecov.
|
markov00
requested changes
Jun 24, 2020
There was a problem hiding this comment.
There are some issues with the computed padding in percentage that can be shown in the following story: http://localhost:9001/?path=/story/bar-chart--scale-to-extent
The positive and negative added padding doesn't represent exactly the applied values
nickofthyme
force-pushed
the
feat/add-domain-padding
branch
from
55137a9 to
053fd69
Compare
- avoid mutating stack/non-stacked domains before combining - update scale to extent story
nickofthyme
force-pushed
the
feat/add-domain-padding
branch
from
053fd69 to
8374e5f
Compare
markov00
reviewed
Jun 29, 2020
markov00
requested changes
Jun 29, 2020
|
🎉 This PR is included in version 19.7.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
AMoo-Miki
pushed a commit
to AMoo-Miki/OpenSearch-Dashboards
that referenced
this pull request
Feb 10, 2022
# [19.7.0](elastic/elastic-charts@v19.6.3...v19.7.0) (2020-06-30) ### Bug Fixes * **partition:** linked label on a larger than 180 degree slice ([opensearch-project#726](elastic/elastic-charts#726)) ([7ac128e](elastic/elastic-charts@7ac128e)), closes [opensearch-project#699](elastic/elastic-charts#699) ### Features * add domain padding ([opensearch-project#707](elastic/elastic-charts#707)) ([8084e4b](elastic/elastic-charts@8084e4b)), closes [opensearch-project#706](elastic/elastic-charts#706)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
fixes #706
yScaleToDataExtentin favor ofdomain.fitChecklist
src/index.ts(and stories only import from../srcexcept for test data & storybook)