Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mage notice target #3772

Merged
merged 5 commits into from
Dec 4, 2023
Merged

Conversation

aleksmaus
Copy link
Contributor

What does this PR do?

Adds mage notice target

Why is it important?

Convenient for magicians

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in ./changelog/fragments using the changelog tool
  • I have added an integration test or an E2E test

Screenshots

Screenshot 2023-11-15 at 12 24 47 PM

@elasticmachine
Copy link
Contributor

elasticmachine commented Nov 15, 2023

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-11-15T18:14:52.770+0000

  • Duration: 53 min 58 sec

❕ Flaky test report

No test was executed to be analysed.

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages.

  • run integration tests : Run the Elastic Agent Integration tests.

  • run end-to-end tests : Generate the packages and run the E2E Tests.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@aleksmaus aleksmaus marked this pull request as ready for review November 16, 2023 14:32
@aleksmaus aleksmaus requested a review from a team as a code owner November 16, 2023 14:32
@aleksmaus aleksmaus requested a review from pchila November 16, 2023 14:32
@aleksmaus
Copy link
Contributor Author

buildkite test this

@aleksmaus
Copy link
Contributor Author

the integrations tests failure is unrelated to this change, can be merged any time

@pchila
Copy link
Member

pchila commented Nov 20, 2023

buildkite test this

@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Nov 20, 2023
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent (Team:Elastic-Agent)

@aleksmaus
Copy link
Contributor Author

@AndersonQ if you have force merge permissions feels free to merge this PR. CI keeps failing on unrelated to this PR issue.

@AndersonQ
Copy link
Member

@aleksmaus I do not have. You can try updating it with main or asking @cmacknz to force merge it

Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@aleksmaus aleksmaus merged commit 8082519 into elastic:main Dec 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip enhancement New feature or request skip-changelog Team:Elastic-Agent Label for the Agent team
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants