Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue #147

Merged
merged 5 commits into from
Aug 28, 2023
Merged

Fix issue #147

merged 5 commits into from
Aug 28, 2023

Conversation

belimawr
Copy link
Contributor

What does this PR do?

It fixes some issues

Why is it important?

It fixes some issues

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

## Author's Checklist
## Related issues

@belimawr belimawr requested a review from a team as a code owner August 28, 2023 09:39
@belimawr belimawr requested review from fearful-symmetry and leehinman and removed request for a team August 28, 2023 09:39
@pierrehilbert pierrehilbert requested a review from rdner August 28, 2023 09:58
@pierrehilbert pierrehilbert added the Team:Elastic-Agent Label for the Agent team label Aug 28, 2023
rdner
rdner approved these changes Aug 28, 2023
View reviewed changes
Copy link
Member

@rdner rdner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good comments in the code, thanks!

@belimawr
Copy link
Contributor Author

I rebased onto main to fix the merge conflicts.

@belimawr
Fix IP Validation for TLS clients
9c27d4c 
This commit fixes the IP validation on TLS clients. When establishing
a TLS connection if the connection used an IP address it was not
validated against the TLS certificate.
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

History

@belimawr belimawr merged commit 4dea101 into elastic:main Aug 28, 2023
@belimawr belimawr deleted the fix-issue branch August 28, 2023 11:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rdner rdner rdner approved these changes

@fearful-symmetry fearful-symmetry Awaiting requested review from fearful-symmetry fearful-symmetry is a code owner automatically assigned from elastic/elastic-agent-data-plane

@leehinman leehinman Awaiting requested review from leehinman leehinman is a code owner automatically assigned from elastic/elastic-agent-data-plane

Assignees
No one assigned
Labels
Team:Elastic-Agent Label for the Agent team
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@belimawr @elasticmachine @rdner @pierrehilbert