Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fleet client] Do not send Agent IDs in request bodies #131

Merged
merged 1 commit into from
Jun 8, 2023

Conversation

ycombinator
Copy link
Contributor

@ycombinator ycombinator commented Jun 8, 2023

What does this PR do?

This PR fixes the Fleet client, specifically for the Upgrade Agent and Un-enroll Agent API calls, to not send the Agent IDs in the request bodies of these APIs.

Why is it important?

For these API calls to work as expected. Needed by elastic/elastic-agent#2809.

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.md

@ycombinator ycombinator requested a review from a team as a code owner June 8, 2023 18:30
@ycombinator ycombinator requested review from pierrehilbert and removed request for a team June 8, 2023 18:30
@elasticmachine
Copy link
Collaborator

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2023-06-08T18:31:12.564+0000

  • Duration: 9 min 36 sec

Test stats 🧪

Test Results
Failed 0
Passed 787
Skipped 11
Total 798

🤖 GitHub comments

Expand to view the GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

@ycombinator ycombinator merged commit 1f368a5 into elastic:main Jun 8, 2023
@ycombinator ycombinator deleted the kib-client-fleet-fix-id branch June 8, 2023 18:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants