Cleanup: Remove // +build lines
#117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ycombinator
requested review from
rdner and
faec
and removed request for
a team
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
🤖 GitHub commentsExpand to view the GitHub comments
To re-run your PR in the CI, just comment with:
|
rdner
approved these changes
Apr 27, 2023
|
The linter failures are fine, there is no actual code change in this PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR runs
go fix -fix buildtag ./...on theelastic-agent-libscodebase to remove the deprecated// +buildbuild tags from.gosource files.Why is it important?
Starting with Go 1.17,
//go:buildtags are preferred over the more bespoke// +buildtags, for consistency with other//go:directives. Starting with Go 1.18,go fixis able to remove the deprecated// +buildtags and only leave the corresponding//go:buildtags in their place.More here: https://go.dev/doc/go1.18#go-build-lines