Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix link rendering issues and usage of http in links #2423

Merged
merged 5 commits into from
Jan 17, 2025

Conversation

taylor-swanson
Copy link
Contributor

@taylor-swanson taylor-swanson commented Jan 15, 2025

Description

  • Removed link text markup, causes issues since final rendering of docs can be in either markdown or asciidoc
  • Replace http with https in links

Related Issues

- Removed link text markup
- Replace http with https in links
@taylor-swanson taylor-swanson self-assigned this Jan 15, 2025
@taylor-swanson taylor-swanson requested a review from a team as a code owner January 15, 2025 16:28
Copy link

Documentation changes preview: https://ecs_bk_2423.docs-preview.app.elstc.co/diff

Copy link
Contributor

@mjwolf mjwolf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I checked that there are no other markdown or asciidoc formatted links in the schema files too

@taylor-swanson taylor-swanson merged commit 66bd6dd into elastic:main Jan 17, 2025
2 checks passed
@taylor-swanson taylor-swanson deleted the fix/links branch January 17, 2025 15:05
mjwolf pushed a commit to mjwolf/ecs that referenced this pull request Jan 17, 2025
…lastic#2423)

- Removed link text markup, causes issues since final rendering of docs can be in either markdown or asciidoc
- Replace http with https in links
mjwolf added a commit that referenced this pull request Jan 21, 2025
…2423) (#2426)

- Removed link text markup, causes issues since final rendering of docs can be in either markdown or asciidoc
- Replace http with https in links

Co-authored-by: Taylor Swanson <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants