This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
chore: decouple ansible install from execution #2163
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
It separates the single, current shell script execution for provisioning the stack VM in three parts:
.venv-installed
file is not present, create virtualenv and create the filepython-dependencies
file is not present, install them and create the filepyrun
We have added a retry logic for the first two scripts, so that we can control and locate possible network issues for each part of the provisioning code
Why is it important?
Decouple provisioning from execution
Checklist
make unit-test
), and they are passing locallymake notice
in the proper directory)Follow-ups
As @adam-stokes mentioned, having a cache/mirror for the Ansible dependencies could improve the resiliency