This repository has been archived by the owner on Sep 17, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 41
feat: support for running feature files #1193
Merged
adam-stokes
merged 21 commits into
elastic:master
from
mdelapenya:1191-support-running-features
May 26, 2021
Merged
feat: support for running feature files #1193
adam-stokes
merged 21 commits into
elastic:master
from
mdelapenya:1191-support-running-features
May 26, 2021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way each test suite will control its own life cycle
It will accept the file name of a feature file, otherwise, it will run all feature files under the 'features/' directory, as it did before this change.
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
jenkins run the tests please |
mdelapenya
commented
May 24, 2021
cachedout
reviewed
May 25, 2021
Co-authored-by: cachedout <[email protected]>
adam-stokes
approved these changes
May 25, 2021
cachedout
approved these changes
May 26, 2021
kuisathaverat
approved these changes
May 26, 2021
mergify bot
pushed a commit
that referenced
this pull request
May 26, 2021
* chore: update unit tests docs in PR template * docs: document configurations location * docs: document how the CI spreads feature files and tags * chore: extract build logic to commons * chore: create build scripts per test suite This way each test suite will control its own life cycle * chore: update scripts used by CI * chore: remove extracted code from the original makefile * chore: remove unused variables in makefile * docs: update how to use the make goals * fix: move build-docs back to the original makefile * chore: move lint back to the original makefile * feat: support passing feature file to the test runner It will accept the file name of a feature file, otherwise, it will run all feature files under the 'features/' directory, as it did before this change. * docs: add features to the docs * docs: document TAGS and FEATURES as variables affecting the build * fix: update tag in docs * docs: include default value for features * chore: move SKIP_SCENARIOS next to related * docs: explain that SKIP is added to the TAGS variable * fix: typo * chore: grammar in docs Co-authored-by: cachedout <[email protected]> Co-authored-by: cachedout <[email protected]> Co-authored-by: Adam Stokes <[email protected]> (cherry picked from commit 888ecfe)
mergify bot
pushed a commit
that referenced
this pull request
May 26, 2021
* chore: update unit tests docs in PR template * docs: document configurations location * docs: document how the CI spreads feature files and tags * chore: extract build logic to commons * chore: create build scripts per test suite This way each test suite will control its own life cycle * chore: update scripts used by CI * chore: remove extracted code from the original makefile * chore: remove unused variables in makefile * docs: update how to use the make goals * fix: move build-docs back to the original makefile * chore: move lint back to the original makefile * feat: support passing feature file to the test runner It will accept the file name of a feature file, otherwise, it will run all feature files under the 'features/' directory, as it did before this change. * docs: add features to the docs * docs: document TAGS and FEATURES as variables affecting the build * fix: update tag in docs * docs: include default value for features * chore: move SKIP_SCENARIOS next to related * docs: explain that SKIP is added to the TAGS variable * fix: typo * chore: grammar in docs Co-authored-by: cachedout <[email protected]> Co-authored-by: cachedout <[email protected]> Co-authored-by: Adam Stokes <[email protected]> (cherry picked from commit 888ecfe)
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
May 26, 2021
* master: feat: support for running feature files (elastic#1193)
adam-stokes
pushed a commit
that referenced
this pull request
May 27, 2021
* chore: update unit tests docs in PR template * docs: document configurations location * docs: document how the CI spreads feature files and tags * chore: extract build logic to commons * chore: create build scripts per test suite This way each test suite will control its own life cycle * chore: update scripts used by CI * chore: remove extracted code from the original makefile * chore: remove unused variables in makefile * docs: update how to use the make goals * fix: move build-docs back to the original makefile * chore: move lint back to the original makefile * feat: support passing feature file to the test runner It will accept the file name of a feature file, otherwise, it will run all feature files under the 'features/' directory, as it did before this change. * docs: add features to the docs * docs: document TAGS and FEATURES as variables affecting the build * fix: update tag in docs * docs: include default value for features * chore: move SKIP_SCENARIOS next to related * docs: explain that SKIP is added to the TAGS variable * fix: typo * chore: grammar in docs Co-authored-by: cachedout <[email protected]> Co-authored-by: cachedout <[email protected]> Co-authored-by: Adam Stokes <[email protected]> (cherry picked from commit 888ecfe) Co-authored-by: Manuel de la Peña <[email protected]>
adam-stokes
pushed a commit
that referenced
this pull request
May 27, 2021
* chore: update unit tests docs in PR template * docs: document configurations location * docs: document how the CI spreads feature files and tags * chore: extract build logic to commons * chore: create build scripts per test suite This way each test suite will control its own life cycle * chore: update scripts used by CI * chore: remove extracted code from the original makefile * chore: remove unused variables in makefile * docs: update how to use the make goals * fix: move build-docs back to the original makefile * chore: move lint back to the original makefile * feat: support passing feature file to the test runner It will accept the file name of a feature file, otherwise, it will run all feature files under the 'features/' directory, as it did before this change. * docs: add features to the docs * docs: document TAGS and FEATURES as variables affecting the build * fix: update tag in docs * docs: include default value for features * chore: move SKIP_SCENARIOS next to related * docs: explain that SKIP is added to the TAGS variable * fix: typo * chore: grammar in docs Co-authored-by: cachedout <[email protected]> Co-authored-by: cachedout <[email protected]> Co-authored-by: Adam Stokes <[email protected]> (cherry picked from commit 888ecfe) Co-authored-by: Manuel de la Peña <[email protected]>
8 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
This PR adds support for running feature files, without changing how the TAGS filters are used.
We are also documenting how the CI is spreading the scenarios in the workers, using the
.e2e-tests.yaml
descriptor.Finally, it improves the docs related the variables that affect the build, including TAGS and FEATURES.
Why is it important?
This PR is the first step to simplify how the scenarios are spread in the parallel workers: nowadays it's using TAGS, but and the end of the day we are using feature files (using the tag for the entire feature file).
Checklist
make unit-test
), and they are passing locallymake notice
in the proper directory)How to test this PR locally
Default execution:
It will run all feature files, filtered by the
backend_processes && debian && install
tags.TAGS="backend_processes && debian && install" TIMEOUT_FACTOR=3 LOG_LEVEL=TRACE BEATS_USE_CI_SNAPSHOT=true DEVELOPER_MODE=true make -C e2e functional-test
Running with features:
It will run the
fleet_mode_agent.feature
file, filtering by thebackend_processes && debian && install
tags.Related issues
Follow-ups
We need to update the e2e YAML descriptor to match this new features approach, updating the Jenkinsfile to spread feature files into the parallel execution. Besides that, we could generate the descriptor on the fly, based on the existing feature files.