Skip to content
This repository has been archived by the owner on Sep 17, 2024. It is now read-only.

Commit

Permalink
fix: hide IntegrationPackage.ID from JSON (#1211) (#1215)
Browse files Browse the repository at this point in the history
* fix: hide IntegrationPackage.ID from JSON

This way, the requests to Kibana won't contain that field, honouring Kibana's contract about fleet schema

* fix: run tests when changing internal

(cherry picked from commit 9430a9a)

Co-authored-by: Manuel de la Peña <[email protected]>
  • Loading branch information
mergify[bot] and mdelapenya authored Jun 1, 2021
1 parent 0393145 commit 049160e
Show file tree
Hide file tree
Showing 2 changed files with 2 additions and 2 deletions.
2 changes: 1 addition & 1 deletion .ci/Jenkinsfile
Original file line number Diff line number Diff line change
Expand Up @@ -250,7 +250,7 @@ def checkTestSuite(Map parallelTasks = [:], Map item = [:]) {
item.scenarios.each { scenario ->
def pullRequestFilter = scenario.containsKey('pullRequestFilter') ? scenario.pullRequestFilter : ''
def tags = scenario.tags
def regexps = [ "^e2e/_suites/${suite}/.*", "^.ci/.*", "^cli/.*", "^e2e/.*\\.go" ]
def regexps = [ "^e2e/_suites/${suite}/.*", "^.ci/.*", "^cli/.*", "^e2e/.*\\.go", "^internal/.*\\.go" ]
if ("${FORCE_SKIP_GIT_CHECKS}" == "true" || isGitRegionMatch(patterns: regexps, shouldMatchAll: false)) {
platforms.each { platform ->
log(level: 'INFO', text: "Adding ${platform}:${suite}:${tags} test suite to the build execution")
Expand Down
2 changes: 1 addition & 1 deletion internal/kibana/integrations.go
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,7 @@ import (

// IntegrationPackage used to share information about a integration
type IntegrationPackage struct {
ID string `json:"id,omitempty"`
ID string `json:"-"`
Name string `json:"name"`
Title string `json:"title"`
Version string `json:"version"`
Expand Down

0 comments on commit 049160e

Please sign in to comment.