Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DOCS] Fix hard-coded links to master #265

Merged
merged 1 commit into from
Jan 30, 2025
Merged

Conversation

lcawl
Copy link
Contributor

@lcawl lcawl commented Jan 30, 2025

Relates to elastic/docs#3160

This PR fixes broken links like:


INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/serverless/main/what-is-elasticsearch-serverless.html contains broken links to:
--
  | INFO:build_docs:   - en/kibana/master/playground.html

INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/serverless/main/elasticsearch-playground.html contains broken links to:
--
  | INFO:build_docs:   - en/kibana/master/playground.html
  | INFO:build_docs:  /tmp/docsbuild/target_repo/html/en/serverless/main/general-ml-nlp-auto-scale.html contains broken links to:
  | INFO:build_docs:   - en/elasticsearch/reference/master/infer-service-elasticsearch.html
  | INFO:build_docs:   - en/elasticsearch/reference/master/infer-service-elser.html
  | INFO:build_docs:   - en/elasticsearch/reference/master/put-inference-api.html
  | INFO:build_docs:   - en/elasticsearch/reference/master/start-trained-model-deployment.html
  | INFO:build_docs:   - en/elasticsearch/reference/master/update-trained-model-deployment.html

I think this PR only needs to be merged if we assume that we'll want to stop the main branch of the Kibana Guide before we stop building the only branch of the Serverless Guide.

@lcawl lcawl requested a review from a team as a code owner January 30, 2025 07:44
Copy link
Contributor

@leemthompo leemthompo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks Lisa!

@leemthompo leemthompo merged commit d85daf0 into elastic:main Jan 30, 2025
2 of 3 checks passed
@lcawl lcawl deleted the doc-links branch January 30, 2025 16:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants