SharePoint Online Connector: Added credentials.close() call to _fetch_token() method #3177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jedrazb
approved these changes
Feb 5, 2025
|
@jedrazb yup, I was! Artem helped me repro the bug when I couldn't figure it out, there is a slack thread here --> https://elastic.slack.com/archives/C01795T48LQ/p1738351743527109 |
github-actions bot
pushed a commit
that referenced
this pull request
Feb 5, 2025
…_token() method (#3177)
mattnowzari
added a commit
that referenced
this pull request
Feb 5, 2025
…_fetch_token() method (#3177) (#3179) Co-authored-by: Matt Nowzari <[email protected]>
|
@mattnowzari I think this should be backported farther than 9.0, original PR was backported up to 8.16.x: #3064 |
|
@artem-shelkovnikov sounds good! Was not aware of the original PR and how far it had been backported, will backport to every version #3064 was ported to |
💚 All backports created successfully
Questions ?Please refer to the Backport tool documentation |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/elastic/search-team/issues/9195
This fixes an issue where
Unclosed client sessionandUnclosed connectormessages were appearing in logs.RCA:
aiohttp does not close its sessions, so when we create an Azure CertificateCredential, we need to manually call
.close()on it, otherwise the client sessions will remain open.See this Azure Python SDK thread for details.
Checklists
Pre-Review Checklist
config.yml.example)v7.13.2,v7.14.0,v8.0.0)