Remove automatically deleting indices for orphaned jobs #2038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanstory
approved these changes
Jan 9, 2024
💔 Failed to create backport PR(s)
To backport manually run: |
seanstory
pushed a commit
that referenced
this pull request
Jan 9, 2024
(cherry picked from commit 2ecbfed) # Conflicts: # connectors/services/job_cleanup.py # tests/services/test_job_cleanup.py
seanstory
pushed a commit
that referenced
this pull request
Jan 9, 2024
(cherry picked from commit 2ecbfed) # Conflicts: # connectors/services/job_cleanup.py # tests/services/test_job_cleanup.py
seanstory
pushed a commit
that referenced
this pull request
Jan 9, 2024
(cherry picked from commit 2ecbfed) # Conflicts: # connectors/services/job_cleanup.py # tests/services/test_job_cleanup.py
💚 All backports created successfully
Note: Successful backport PRs will be merged automatically after passing CI. Questions ?Please refer to the Backport tool documentation |
6 tasks
seanstory
added a commit
that referenced
this pull request
Jan 9, 2024
#2039) Co-authored-by: Sander Philipse <[email protected]>
seanstory
added a commit
that referenced
this pull request
Jan 11, 2024
#2041) Co-authored-by: Sander Philipse <[email protected]>
seanstory
added a commit
that referenced
this pull request
Jan 12, 2024
#2040) Co-authored-by: Sander Philipse <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
relates to: https://github.com/elastic/enterprise-search-team/issues/6075
This removes deleting indices for orphaned jobs, as we may be inadvertently deleting indices that should be kept in some edge cases.
Release note
On some edge cases where Elasticsearch is facing issues we may be inadvertently deleting content indices, because we incorrectly think the index has been deleted. This change removes the step where we delete indices.