Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CLI] Add documentation #2031

Merged
merged 3 commits into from
Jan 9, 2024
Merged

[CLI] Add documentation #2031

merged 3 commits into from
Jan 9, 2024

Conversation

vidok
Copy link
Contributor

@vidok vidok commented Jan 7, 2024

Closes https://github.com/elastic/enterprise-search-team/issues/6506

This adds a Connectors CLI documentation page.

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • this PR has a thorough description
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)
  • Considered corresponding documentation changes

@vidok vidok requested a review from a team January 7, 2024 22:18
@vidok vidok added the v8.12.0 label Jan 7, 2024
Copy link
Member

@wangch079 wangch079 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not related to this PR.

When we run make clean install, we also install elastic-ingest, which is used to

  1. run the connector service (./bin/elastic-ingest)
  2. list all the available sources (./bin/elastic-ingest --action list)
  3. get the default configuration of a service type (./bin/elastic-ingest --action config --service-type mongodb)
  4. clean up sync jobs (./bin/elastic-ingest --action cleanup)

WDYT if we merge the above functionalities into the CLI so we only need to install one connectors.


Examples
```bash
./bin/connectors job list -- <connector_id>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it a common practice to use -- to specify an ID? I also see -- in Job start example below which is not used for an ID.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not super common however it helps to avoid errors when an Elasticsearch document starts with -. See https://github.com/elastic/enterprise-search-team/issues/6440 to get more information.

@vidok
Copy link
Contributor Author

vidok commented Jan 8, 2024

Not related to this PR.

When we run make clean install, we also install elastic-ingest, which is used to

  1. run the connector service (./bin/elastic-ingest)
  2. list all the available sources (./bin/elastic-ingest --action list)
  3. get the default configuration of a service type (./bin/elastic-ingest --action config --service-type mongodb)
  4. clean up sync jobs (./bin/elastic-ingest --action cleanup)

WDYT if we merge the above functionalities into the CLI so we only need to install one connectors.

Yes, this is a good idea. We can probably move everything related to "connector service" under "./bin/connectorts service" namespace.

@vidok vidok requested review from wangch079 and a team January 8, 2024 15:15
@vidok vidok force-pushed the dmitrii/6506-cli-documentation branch from d620640 to 95f8350 Compare January 8, 2024 15:59
@vidok vidok merged commit e377d01 into main Jan 9, 2024
@vidok vidok deleted the dmitrii/6506-cli-documentation branch January 9, 2024 10:01
github-actions bot pushed a commit that referenced this pull request Jan 9, 2024
Copy link

github-actions bot commented Jan 9, 2024

💚 Backport PR(s) successfully created

Status Branch Result
8.12 #2033

This backport PR will be merged automatically after passing CI.

vidok added a commit that referenced this pull request Jan 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants