Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update aiohttp to latest #2019

Merged
merged 3 commits into from
Jan 2, 2024
Merged

Update aiohttp to latest #2019

merged 3 commits into from
Jan 2, 2024

Conversation

artem-shelkovnikov
Copy link
Member

@artem-shelkovnikov artem-shelkovnikov commented Dec 28, 2023

Closes #1939

Updating aiohttp to 3.9.0 + updating aioresponses to 0.7.6 - aioresponses is used for mocking aiohttp server responses and current version is not compatible with new aiohttp.

Checklists

Pre-Review Checklist

  • this PR has a meaningful title
  • this PR links to all relevant github issues that it fixes or partially addresses
  • if there is no GH issue, please create it. Each PR should have a link to an issue
  • this PR has a thorough description
  • Covered the changes with automated tests
  • Added a label for each target release version (example: v7.13.2, v7.14.0, v8.0.0)

@@ -1,4 +1,4 @@
aiohttp==3.8.6
aiohttp==3.9.0
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Consider upgrading to the latest 3.9.1: https://pypi.org/project/aiohttp/#history

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call! Done :)

@artem-shelkovnikov artem-shelkovnikov requested a review from a team January 2, 2024 11:25
@artem-shelkovnikov artem-shelkovnikov enabled auto-merge (squash) January 2, 2024 16:16
@artem-shelkovnikov artem-shelkovnikov merged commit c23c8b0 into main Jan 2, 2024
@artem-shelkovnikov artem-shelkovnikov deleted the artem/upgrade-aiohttp branch January 2, 2024 16:23
Copy link

github-actions bot commented Jan 2, 2024

💔 Failed to create backport PR(s)

The backport operation could not be completed due to the following error:
There are no branches to backport to. Aborting.

The backport PRs will be merged automatically after passing CI.

To backport manually run:
backport --pr 2019 --autoMerge --autoMergeMethod squash

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update aiohttp to 3.9
2 participants