Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update documentation and samples to use node.roles #3719

Merged
merged 4 commits into from
Sep 8, 2020

Conversation

charith-elastic
Copy link
Contributor

Uses node.roles instead of node.{role_name} in the documentation and samples.

Fixes #3410

@thbkrkr
Copy link
Contributor

thbkrkr commented Sep 7, 2020

I guess elasticsearch/orchestration.asciidoc fell through the cracks because we forgot the node. prefix there (highlighted with #3699). Maybe it's the occasion to tackle it to not forget it?

Copy link
Contributor

@sebgl sebgl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
I hope we eventually find a better solution for the coordinator node :/

@charith-elastic
Copy link
Contributor Author

@elasticmachine run elasticsearch-ci/docs

@charith-elastic charith-elastic merged commit 7107ed6 into elastic:master Sep 8, 2020
@charith-elastic charith-elastic deleted the docs/node-roles branch September 8, 2020 14:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>docs Documentation v1.3.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Node roles: update documentation
3 participants