Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always include Pod UID as part of Pod metadata #9517

Merged
merged 5 commits into from
Dec 14, 2018

Conversation

exekias
Copy link
Contributor

@exekias exekias commented Dec 12, 2018

We realized Pod UID is a really useful info to have around so we are
always including it.

Users wanted to opt-out from this can use the drop_fields processor
like this:

processors:
  - drop_fields:
      fields: ["kubernetes.pod.uid"]

closes #9360

@exekias exekias added review libbeat containers Related to containers use case labels Dec 12, 2018
We realized Pod UID is a really useful info to have around so we are
always including it.

Users wanted to opt-out from this can use the `drop_fields` processor
like this:

```
processors:
  - drop_fields:
      fields: ["kubernetes.pod.uid"]
```
@exekias exekias added needs_backport PR is waiting to be backported to other branches. v6.6.0 labels Dec 12, 2018
@kaiyan-sheng
Copy link
Contributor

Any documentation needs to be updated here?

@exekias
Copy link
Contributor Author

exekias commented Dec 13, 2018

Yes! thank you for bringing it up, as this was an undocumented feature (intended that way), I have only updated the points where we explain the resulting fields

@ruflin ruflin added the Team:Integrations Label for the Integrations team label Dec 13, 2018
@elasticmachine
Copy link
Collaborator

Pinging @elastic/infrastructure

Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ignore the killed OS X build.

@ruflin ruflin self-assigned this Dec 14, 2018
@ruflin ruflin merged commit 571b882 into elastic:master Dec 14, 2018
ruflin pushed a commit to ruflin/beats that referenced this pull request Dec 14, 2018
We realized Pod UID is a really useful info to have around so we are
always including it.

Users wanted to opt-out from this can use the `drop_fields` processor
like this:

```
processors:
  - drop_fields:
      fields: ["kubernetes.pod.uid"]
```

closes elastic#9360

(cherry picked from commit 571b882)
@ruflin ruflin removed the needs_backport PR is waiting to be backported to other branches. label Dec 14, 2018
@ruflin ruflin added the v6.5.4 label Dec 14, 2018
ruflin pushed a commit to ruflin/beats that referenced this pull request Dec 14, 2018
We realized Pod UID is a really useful info to have around so we are
always including it.

Users wanted to opt-out from this can use the `drop_fields` processor
like this:

```
processors:
  - drop_fields:
      fields: ["kubernetes.pod.uid"]
```

closes elastic#9360

(cherry picked from commit 571b882)
ruflin added a commit that referenced this pull request Dec 17, 2018
We realized Pod UID is a really useful info to have around so we are
always including it.

Users wanted to opt-out from this can use the `drop_fields` processor
like this:

```
processors:
  - drop_fields:
      fields: ["kubernetes.pod.uid"]
```

closes #9360

(cherry picked from commit 571b882)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
containers Related to containers use case libbeat review Team:Integrations Label for the Integrations team v6.5.4 v6.6.0
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enable Pod UID metadata by default
4 participants