-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always include Pod UID as part of Pod metadata #9517
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We realized Pod UID is a really useful info to have around so we are always including it. Users wanted to opt-out from this can use the `drop_fields` processor like this: ``` processors: - drop_fields: fields: ["kubernetes.pod.uid"] ```
bfb83be
to
812047d
Compare
Any documentation needs to be updated here? |
Yes! thank you for bringing it up, as this was an undocumented feature (intended that way), I have only updated the points where we explain the resulting fields |
Pinging @elastic/infrastructure |
ruflin
approved these changes
Dec 13, 2018
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Ignore the killed OS X build.
kaiyan-sheng
approved these changes
Dec 13, 2018
ruflin
pushed a commit
to ruflin/beats
that referenced
this pull request
Dec 14, 2018
We realized Pod UID is a really useful info to have around so we are always including it. Users wanted to opt-out from this can use the `drop_fields` processor like this: ``` processors: - drop_fields: fields: ["kubernetes.pod.uid"] ``` closes elastic#9360 (cherry picked from commit 571b882)
ruflin
pushed a commit
to ruflin/beats
that referenced
this pull request
Dec 14, 2018
We realized Pod UID is a really useful info to have around so we are always including it. Users wanted to opt-out from this can use the `drop_fields` processor like this: ``` processors: - drop_fields: fields: ["kubernetes.pod.uid"] ``` closes elastic#9360 (cherry picked from commit 571b882)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
containers
Related to containers use case
libbeat
review
Team:Integrations
Label for the Integrations team
v6.5.4
v6.6.0
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We realized Pod UID is a really useful info to have around so we are
always including it.
Users wanted to opt-out from this can use the
drop_fields
processorlike this:
closes #9360