Compress docker artifacts with gzip #9223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
urso
reviewed
Nov 23, 2018
urso
reviewed
Nov 24, 2018
dev-tools/mage/dockerbuilder.go
Outdated
| if err := sh.Run("docker", "save", "-o", outputFile, tag); err != nil { | ||
| var stderr bytes.Buffer | ||
| cmd := exec.Command("docker", "save", tag) | ||
| cmd.Stderr = bufio.NewWriter(&stderr) |
There was a problem hiding this comment.
Why wrap a bytes.Buffer into bufio.NewWriter?
There was a problem hiding this comment.
You are right, this is not needed, removed.
|
jenkins, test this again |
|
Updated branch with master to skip flaky tests (#9217) |
graphaelli
reviewed
Nov 26, 2018
graphaelli
approved these changes
Nov 26, 2018
urso
approved these changes
Nov 26, 2018
|
Thanks both for the reviews! |
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Dec 7, 2018
(cherry picked from commit 675f2b0)
jsoriano
added a commit
that referenced
this pull request
Dec 8, 2018
…uilding packages (#9433) Include generation of docker images in the process of building the rest of released packages by extending `mage package`. (#8898) (cherry picked from commit 9294384) Tag container images with snapshot information (#9063) (cherry picked from commit 1dd4fbf) * Compress docker artifacts with gzip (#9223) (cherry picked from commit 675f2b0) Co-authored-by: Gil Raphaelli <[email protected]>
jsoriano
added a commit
to jsoriano/beats
that referenced
this pull request
Feb 27, 2019
… docker images when building packages (elastic#9433) Include generation of docker images in the process of building the rest of released packages by extending `mage package`. (elastic#8898) (cherry picked from commit 9294384) Tag container images with snapshot information (elastic#9063) (cherry picked from commit 1dd4fbf) * Compress docker artifacts with gzip (elastic#9223) (cherry picked from commit 675f2b0) Co-authored-by: Gil Raphaelli <[email protected]>
DStape
pushed a commit
to DStape/beats
that referenced
this pull request
Aug 20, 2019
… docker images when building packages (elastic#9433) Include generation of docker images in the process of building the rest of released packages by extending `mage package`. (elastic#8898) (cherry picked from commit 9294384) Tag container images with snapshot information (elastic#9063) (cherry picked from commit 1dd4fbf) * Compress docker artifacts with gzip (elastic#9223) (cherry picked from commit 675f2b0) Co-authored-by: Gil Raphaelli <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.