Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Index cluster.id and cluster.name in elasticsearch/index_recovery metricset #9164

Merged
merged 2 commits into from
Nov 20, 2018
Merged

Index cluster.id and cluster.name in elasticsearch/index_recovery metricset #9164

merged 2 commits into from
Nov 20, 2018

Conversation

ycombinator
Copy link
Contributor

This PR teaches the elasticsearch/index_recovery metricset to index the Elasticsearch cluster_uuid and cluster_name as the module-level cluster.id and cluster.name fields, respectively.

@ycombinator ycombinator added review Metricbeat Metricbeat needs_backport PR is waiting to be backported to other branches. v7.0.0-alpha1 v6.6.0 labels Nov 20, 2018
@ycombinator ycombinator requested a review from ruflin November 20, 2018 02:29
ruflin
ruflin approved these changes Nov 20, 2018
View reviewed changes
Copy link
Contributor

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Changelog?

@ycombinator
Copy link
Contributor Author

Changelog?

I think in general yes but these fields (cluster_uuid and cluster_name) were a miss. They should've been there to begin with because some other metricsets in this module have them but some don't.

I say we add CHANGELOG entries for new fields once the module goes GA?

@ruflin
Copy link
Contributor

ruflin commented Nov 20, 2018

I think as soon as something is shipped in a release, we should add changelog entries independent on the release status it is in. We can perhaps have a more generic changelog entry for all the PR that add cluster id / name.

@ycombinator
Copy link
Contributor Author

ycombinator commented Nov 20, 2018 •
edited
Loading

Sounds good, I'll add a general CHANGELOG entry to the last of these PRs thats about to get merged in.

@ycombinator ycombinator merged commit 05b63e9 into elastic:master Nov 20, 2018
@ycombinator ycombinator deleted the metricbeat-elasticsearch-index-recovery-cluster-id branch November 20, 2018 13:45
@ycombinator ycombinator mentioned this pull request Nov 20, 2018
Merged
@ycombinator ycombinator removed the needs_backport PR is waiting to be backported to other branches. label Nov 20, 2018
ycombinator added a commit that referenced this pull request Nov 20, 2018
@ycombinator
Cherry-pick #9164 to 6.x: Index cluster.id and cluster.name in elasti…
0a693cf 
…csearch/index_recovery metricset (#9175)

Cherry-pick of PR #9164 to 6.x branch. Original message: 

This PR teaches the `elasticsearch/index_recovery` metricset to index the Elasticsearch `cluster_uuid` and `cluster_name` as the module-level `cluster.id` and `cluster.name` fields, respectively.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

Assignees
No one assigned
Labels
Metricbeat Metricbeat review v6.6.0 v7.0.0-alpha1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ycombinator @ruflin