Cherry-pick #9062 to 6.x: Fix keystore's flaky tests #9098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We are now using Mockbeat and the file output instead of using the ES output and we now assert the Keystore log message, this should make the test more stable and faster to run. Fix the following: ``` test_keystore_with_present_key failed 3 times: elastic+beats+master+multijob-windows/beat=libbeat,label=windows failed 2 times elastic+beats+6.x+multijob-darwin/beat=libbeat,label=macosx failed 1 times test_keystore_with_nested_key failed 2 times: elastic+beats+6.5+multijob-windows/beat=libbeat,label=windows failed 1 times elastic+beats+master+multijob-windows/beat=libbeat,label=windows failed 1 times ``` (cherry picked from commit 2f9f021)
jsoriano
approved these changes
Nov 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of PR #9062 to 6.x branch. Original message:
We are now using Mockbeat and the file output instead of using the ES
output and we now assert the Keystore log message, this should make the
test more stable and faster to run.
Fix the following: