Remove 5.x obsolete options checks #9002
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ph
added
in progress
20 tasks
ph
changed the title
|
Jenkins test this please |
|
I think there was a problem with the docker on that CI node, I've rekick the Jenkins tests to see if it solve the problem. |
|
The docker error seems to be a problem with our infra, it should be resolved soon. |
ph
changed the title
ph
force-pushed
the
fix/remove-5x-obsolete-options
branch
from
189a2ea to
8a2c019
Compare
|
I do not think the Auditbeat failure is related, this look like the file integrity test failing. |
kvch
reviewed
Nov 13, 2018
| } | ||
|
|
||
| functions := []struct { | ||
| name string | ||
| fn func(*common.Config, ...string) error | ||
| }{ | ||
| {name: "checkRemovedSetting", fn: checkRemovedSettings}, | ||
| {name: "checkRemoved6xSetting", fn: CheckRemoved6xSettings}, | ||
| // {name: "checkRemoved6xSetting", fn: CheckRemoved6xSettings}, |
|
@kvch updated with the uncomment code, I have fat fingers :( |
|
Jenkins test this please |
Since we are moving to 7.0 its a good time to update the code and remove deprecated code and warning for removed options. Remove any 5.x options Add tests for obsolete Filebeat 6.x options
ph
force-pushed
the
fix/remove-5x-obsolete-options
branch
from
d794456 to
0dc8acd
Compare
kvch
approved these changes
Nov 14, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since we are moving to 7.0 its a good time to update the code and remove
deprecated code and warning for removed options.
Remove any 5.x options
Add tests for obsolete Filebeat 6.x options