Removed Envoy entry on docs #8783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruflin
added
the
needs_backport
ruflin
approved these changes
Oct 29, 2018
CHANGELOG.asciidoc
Outdated
| @@ -421,6 +421,7 @@ https://github.com/elastic/beats/compare/v6.3.0...v6.3.1[View commits] | |||
| - Fix field mapping for the system process CPU ticks fields. {pull}7230[7230] | |||
| - Ensure canonical naming for JMX beans is disabled in Jolokia module. {pull}7047[7047] | |||
| - Fix Jolokia attribute mapping when using wildcards and MBean names with multiple properties. {pull}7321[7321] | |||
| - Remove duplicated envoy entry from docs {issue}8759[8759] | |||
There was a problem hiding this comment.
We normally don't add changes about the docs to the changelog.
|
I now realise we should potentially also backport it to 6.4 if the issue is also in the 6.4 docs. |
ruflin
approved these changes
Oct 30, 2018
|
@sayden What is the status here? This probably only needs a rebase. |
This reverts commit ad9765433f86b767e5352c3b5aa958928d64d809.
sayden
force-pushed
the
remove_duplicated_envoy_entry_on_docs
branch
from
b36dfd3 to
dec0e91
Compare
ruflin
approved these changes
Nov 27, 2018
sayden
added
v6.6.0
and removed
needs_backport
sayden
added a commit
to sayden/beats
that referenced
this pull request
Nov 27, 2018
(cherry picked from commit 238e55d)
sayden
added a commit
that referenced
this pull request
Nov 27, 2018
|
Don't forget to backport to 6.5 too 🙂 and maybe to 6.4. |
sayden
added a commit
to sayden/beats
that referenced
this pull request
Nov 27, 2018
(cherry picked from commit 238e55d)
sayden
added a commit
to sayden/beats
that referenced
this pull request
Nov 27, 2018
(cherry picked from commit 238e55d)
sayden
added a commit
that referenced
this pull request
Nov 27, 2018
sayden
added a commit
that referenced
this pull request
Nov 27, 2018
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
(cherry picked from commit 94a0433)
leweafan
pushed a commit
to leweafan/beats
that referenced
this pull request
Apr 28, 2023
(cherry picked from commit 94a0433)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related with this issue #8759
I have run
make updateand it seems that the docs have been updated but I'm still not sure if this is going to solve the conflicting document