Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Experimental fix for Auditbeat recursive test #8317

Closed
wants to merge 1 commit into from

Conversation

andrewvc
Copy link
Contributor

Experimental test for #8208

@andrewvc andrewvc added in progress Pull request is currently in progress. Auditbeat labels Sep 14, 2018
@jsoriano
Copy link
Member

I like this approach to fix these errors. I think this should be used too in the Windows-related if a lines below. And both ifs should be removed as this new method is going to take care of skipping non-interesting events.

Thanks for working on this!

@jsoriano jsoriano added the flaky-test Unstable or unreliable test cases. label Sep 17, 2018
@andrewvc
Copy link
Contributor Author

@jsoriano thanks! The bad news is that this experiment failed. I assumed the root cause was that on win there were two change events, one for the directory, and another for the file.

That appears to not be the case. I won't be able to look at this for at least a few more days, so it'd be good if someone else could tackle this issue since it is so common.

@andrewvc
Copy link
Contributor Author

Actually fixed in #8367

@andrewvc andrewvc closed this Sep 24, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auditbeat flaky-test Unstable or unreliable test cases. in progress Pull request is currently in progress.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants