Force pull of images on make start-environment
#8230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jsoriano
added
:Testing
:Infra
needs_backport
ruflin
approved these changes
Sep 6, 2018
ruflin
reviewed
Sep 6, 2018
| @@ -377,6 +377,7 @@ build-image: write-environment | |||
| # To use it for running the test, set ES_HOST and REDIS_HOST environment variable to the ip of your docker-machine. | |||
| .PHONY: start-environment | |||
| start-environment: stop-environment | |||
| ${DOCKER_COMPOSE} pull --include-deps | |||
There was a problem hiding this comment.
I assume this will use the cached layers if they are available and identical?
There was a problem hiding this comment.
Yes, it still reuses local layers.
There was a problem hiding this comment.
But I see build times increased some minutes... maybe this is normal if we were re-using images too much.
There was a problem hiding this comment.
I think its ok as it gets us on the same page with travis. also if intermediary images used, the increase should only be once a day
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using snapshots, image could be outdated, force pulling images before starting environment.
Ported from #8204