Refactoring: extracting helper function for broader usage #7693
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Rename the xpack helper package to elastic to reflect its broader usage. Extract and generalize the ReportErrorForMissingField helper function into elastic package so it may be used by multiple elastic-related modules.
ycombinator
added
in progress
ycombinator
added
v6.4.0
review
and removed
in progress
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rename the
xpackhelper package toelasticto reflect its broader usage. Extract and generalize theReportErrorForMissingFieldhelper function intoelasticpackage so it may be used by multiple elastic-related modules.