Make Kibana client reusable #7211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change makes Kibana config public, it also includes headers passing.
exekias
force-pushed
the
common-kibana-client
branch
from
c9c1515 to
b0f2289
Compare
ruflin
reviewed
May 31, 2018
| @@ -6,7 +6,8 @@ import ( | |||
| "github.com/elastic/beats/libbeat/common/transport/tlscommon" | |||
| ) | |||
|
|
|||
| type kibanaConfig struct { | |||
| // ClientConfig to connect to Kibana | |||
| type ClientConfig struct { | |||
There was a problem hiding this comment.
Is there an other config then clientConfig for Kibana? Otherwise you could just call it config.
|
Merged, we can still make further adjustments later. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change moves Kibana client to a common place in libbeat, it also makes client config public and adds support for headers passing.