Move file rotator out of logp package #5885
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andrewkroh
force-pushed
the
feature/libbeat/move-file-rotator
branch
2 times, most recently
from
2730eb5 to
2540a56
Compare
ph
approved these changes
Dec 15, 2017
This moves the file rotator utility to the libbeat/common/file package. This utility is used by more things than the just the logger.
andrewkroh
force-pushed
the
feature/libbeat/move-file-rotator
branch
from
2540a56 to
25dcf1b
Compare
|
Rebased. |
|
jenkins test this please |
|
Yay. Green on Jenkins. |
|
@andrewkroh Yeah there was weird error with one of the jenkins node. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the file rotator utility to the libbeat/common/file package. This utility is used by more things than the just the logger.