Add field network_names of hosts and virtual machines to vsphere module #5732
Conversation
|
Can one of the admins verify this patch? |
CHANGELOG.asciidoc
Outdated
| @@ -68,6 +68,9 @@ https://github.com/elastic/beats/compare/v6.0.0-beta2...master[Check the HEAD di | |||
| - Fix error `datastore '*' not found` in Vsphere module. {issue}4879[4879] | |||
| - Fix error `NotAuthenticated` in Vsphere module. {issue}4673[4673] | |||
| - Fix connection leak in mongodb module. {issue}5688[5688] | |||
| - Support `npipe` protocol (Windows) in Docker module. {pull}4751[4751] | |||
| - Added missing mongodb configuration file to the `modules.d` folder. {pull}4870[4870] | |||
| - Fix wrong MySQL CRUD queries timelion visualization {pull}4857[4857] | |||
There was a problem hiding this comment.
It looks like these items are spurious, can you remove them?
| // limitations under the License. | ||
|
|
||
| // Package pbutil provides record length-delimited Protocol Buffer streaming. | ||
| package pbutil |
There was a problem hiding this comment.
any reason to remove this?
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
|
|
||
| package types |
There was a problem hiding this comment.
probably this is an accidental removal
| @@ -35,3 +35,8 @@ | |||
| description: > | |||
| Free Memory in bytes | |||
| format: bytes | |||
| - name: network_names | |||
| type: object | |||
There was a problem hiding this comment.
Why did you go for object? I'm wondering if this should be keyword as this will hold an array?
|
@exekias I think that I did something really crazy with rebase...But now it's fixed (I hope so) and I changed fields.yml like you suggested. |
ruflin
changed the title
ruflin
changed the title
| } | ||
|
|
||
| for _, net := range nets { | ||
| name := strings.Replace(net.Name, ".", "_", -1) |
There was a problem hiding this comment.
We probably should make this a helper function for in beats to "normalise" keys.
|
@exekias I leave this one up to you again to approve / merge. |
There was a problem hiding this comment.
Thank you again for all your contributions @amandahla , you rock! 🚀 🎸
|
Thaaanks! 💃 😄 |
|
How modify ulimit for metricbeat ? Many messages : [vsphere] error retrieving network from virtual machine: object references must have the same type So, then network name is ok like : |
|
@adelbot How is ulimit related to the issue above? Should we take this to discuss https://discuss.elastic.co/c/beats/metricbeat ? @amandahla Perhaps you know more about the error |
|
@ruflin Sorry for the delay, I was traveling on vacation. About "sockets : Too many open files", I'm afraid that vsphere module open too many connections to collect. It shouldn't be a problem because we use "defer client.Logout(ctx)" and the definition says that "Close any idle connections after logging out." |
Add a new field "network_names" to metrics "host" and "virtualmachine".
Closes #5646