Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move content about processors to filtering section in the doc #4149

Merged
merged 1 commit into from
May 4, 2017

Conversation

dedemorton
Copy link
Contributor

@monicasarbu I'd like for you to take a quick look at this before I change the docs for the other beats. I've streamlined the intro because I want users to know that the prospector-level options exist, but I don't think we should cover them in very much detail since the main point of the section (after the reorg) is to cover processors. Here's what the TOC looks like (with some slight changes from your suggested titles because they made the TOC entries harder to scan):

image

@dedemorton dedemorton added docs in progress Pull request is currently in progress. review labels Apr 29, 2017
@monicasarbu
Copy link
Contributor

@dedemorton That looks perfect, thanks.

@dedemorton
Copy link
Contributor Author

OK, I'll apply the same redesign to the docs for the other beats, too.

Reorganize processor content for all the beats
@dedemorton dedemorton removed the in progress Pull request is currently in progress. label May 4, 2017
@dedemorton
Copy link
Contributor Author

This is ready to merge as soon as the tests pass.

@dedemorton
Copy link
Contributor Author

@monicasarbu I'm not planning to backport this to 5.4 unless you think I really need to. Resolving the file conflicts might get a little messy because there are a couple of new processors in master...plus probably some changes. Let me know if you think it's important to backport this.

@monicasarbu
Copy link
Contributor

I think we should introduce these changes for 6.0.0-alpha1. Thanks @dedemorton, this is a big improvement.

@monicasarbu monicasarbu merged commit 1255d84 into elastic:master May 4, 2017
@monicasarbu monicasarbu deleted the beats_issue#4058 branch May 4, 2017 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants