[8.15](backport #40494) x-pack/filebeat/input/entityanalytics/provider/azuread/fetcher/graph: set log max_size #40517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![mergify[bot]](https://avatars.githubusercontent.com/in/10562?s=60&v=4){kind=small}
… set log max_size (#40494) There was no check on the tracer log settings, so the max_size was not being checked for zero. This would result in 100MB log rotation trigger and zero-sized bodies. There is no validation logic to hook this into in the config for the fetcher, so calculate it immediately before use. (cherry picked from commit 08b5628)
botelastic
bot
added
the
needs_team
|
This pull request doesn't have a |
efd6
approved these changes
Aug 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed commit message
There was no check on the tracer log settings, so the max_size was not being checked for zero. This would result in 100MB log rotation trigger and zero-sized bodies. There is no validation logic to hook this into in the config for the fetcher, so calculate it immediately before use.
A fix is already included in the prospective integration change that makes use of this feature.
Checklist
CHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.Disruptive User Impact
Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs
This is an automatic backport of pull request #40494 done by [Mergify](https://mergify.com).