Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker health metricset cleanup #3463

Merged
merged 1 commit into from
Jan 25, 2017
Merged

Docker health metricset cleanup #3463

merged 1 commit into from
Jan 25, 2017

Conversation

ruflin
Copy link
Contributor

@ruflin ruflin commented Jan 25, 2017

  • Update data.json with latest data
  • Clean up variable naming
  • Add system test to also check docs
  • Introduce healthcheck in dockerfile to allow automated testing
  • Update CHANGELOG
  • Rename wrongly named file

@ruflin ruflin mentioned this pull request Jan 25, 2017
Merged
tsg
tsg approved these changes Jan 25, 2017
View reviewed changes
Copy link
Contributor

@tsg tsg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ruflin
Docker health metricset cleanup
7e6f428 
* Update data.json with latest data
* Clean up variable naming
* Add system test to also check docs
* Introduce healthcheck in dockerfile to allow automated testing
* Update CHANGELOG
* Rename wrongly named file
@ruflin ruflin force-pushed the docker-health-cleanup branch from d973b1f to 7e6f428 Compare January 25, 2017 13:33
@tsg tsg merged commit 37ed9da into elastic:master Jan 25, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tsg tsg tsg approved these changes

Assignees
No one assigned
Labels
Metricbeat Metricbeat review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ruflin @tsg