Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[8.3](backport #32010) Expand fields in decode_json_fields if target is set #32015

Closed
wants to merge 1 commit into from

Conversation

mergify[bot]
Copy link
Contributor

@mergify mergify bot commented Jun 21, 2022

This is an automatic backport of pull request #32010 done by Mergify.


Mergify commands and options

More conditions and actions can be found in the documentation.

You can also trigger Mergify actions by commenting on this pull request:

  • @Mergifyio refresh will re-evaluate the rules
  • @Mergifyio rebase will rebase this PR on its base branch
  • @Mergifyio update will merge the base branch into this PR
  • @Mergifyio backport <destination> will backport this PR on <destination> branch

Additionally, on Mergify dashboard you can:

  • look at your merge queues
  • generate the Mergify configuration with the config editor.

Finally, you can contact us on https://mergify.com

## What does this PR do?

This PR applies the settings in `expand_keys` to the event even if the target is not empty.

## Why is it important?

Previously, if target was set to anything besides `""`, `expand_keys` did not work. So you could not expand the keys of the parsed JSON if you wanted to put it under a custom field.

(cherry picked from commit 7b99a8e)
@mergify mergify bot requested a review from a team as a code owner June 21, 2022 15:31
@mergify mergify bot requested review from rdner and fearful-symmetry and removed request for a team June 21, 2022 15:31
@mergify mergify bot added the backport label Jun 21, 2022
@mergify mergify bot assigned kvch Jun 21, 2022
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jun 21, 2022
@botelastic
Copy link

botelastic bot commented Jun 21, 2022

This pull request doesn't have a Team:<team> label.

@kvch kvch closed this Jun 21, 2022
@mergify mergify bot deleted the mergify/bp/8.3/pr-32010 branch June 21, 2022 15:48
@elasticmachine
Copy link
Collaborator

💔 Build Failed

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-06-21T15:31:35.336+0000

  • Duration: 21 min 48 sec

Test stats 🧪

Test Results
Failed 0
Passed 3
Skipped 0
Total 3

Steps errors 17

Expand to view the steps failures

Show only the first 10 steps failures

x-pack/dockerlogbeat-checks - make -C x-pack/dockerlogbeat check;make -C x-pack/dockerlogbeat updat
  • Took 0 min 22 sec . View more details here
  • Description: make -C x-pack/dockerlogbeat check;make -C x-pack/dockerlogbeat update;make check-no-changes;
x-pack/filebeat-checks - make -C x-pack/filebeat check;make -C x-pack/filebeat update;make -C file
  • Took 2 min 44 sec . View more details here
  • Description: make -C x-pack/filebeat check;make -C x-pack/filebeat update;make -C filebeat check;make -C filebeat update;make check-no-changes;
x-pack/functionbeat-checks - make -C x-pack/functionbeat check;make -C x-pack/functionbeat update;
  • Took 1 min 28 sec . View more details here
  • Description: make -C x-pack/functionbeat check;make -C x-pack/functionbeat update;make check-no-changes;
x-pack/heartbeat-checks - make -C x-pack/heartbeat check;make -C x-pack/heartbeat update;make -C h
  • Took 2 min 38 sec . View more details here
  • Description: make -C x-pack/heartbeat check;make -C x-pack/heartbeat update;make -C heartbeat check;make -C heartbeat update;make check-no-changes;
x-pack/libbeat-checks - make -C x-pack/libbeat check;make -C x-pack/libbeat update;make check-no-c
  • Took 2 min 30 sec . View more details here
  • Description: make -C x-pack/libbeat check;make -C x-pack/libbeat update;make check-no-changes;
x-pack/metricbeat-checks - make -C x-pack/metricbeat check;make -C x-pack/metricbeat update;make -
  • Took 2 min 15 sec . View more details here
  • Description: make -C x-pack/metricbeat check;make -C x-pack/metricbeat update;make -C metricbeat check;make -C metricbeat update;make check-no-changes;
x-pack/osquerybeat-checks - make -C x-pack/osquerybeat check;make -C x-pack/osquerybeat update;mak
  • Took 1 min 59 sec . View more details here
  • Description: make -C x-pack/osquerybeat check;make -C x-pack/osquerybeat update;make check-no-changes;
x-pack/packetbeat-checks - make -C packetbeat check;make -C packetbeat update;make check-no-change
  • Took 2 min 39 sec . View more details here
  • Description: make -C packetbeat check;make -C packetbeat update;make check-no-changes;
x-pack/winlogbeat-checks-immutable && ubuntu-18 - make -C x-pack/winlogbeat check;make -C x-pack/wi
  • Took 2 min 31 sec . View more details here
  • Description: make -C x-pack/winlogbeat check;make -C x-pack/winlogbeat update;make -C winlogbeat check;make -C winlogbeat update;make check-no-changes;
Error signal
  • Took 0 min 0 sec . View more details here
  • Description: githubApiCall: The REST API call https://api.github.com/orgs/elastic/members/mergify[bot] return the message : java.lang.Exception: httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/mergify[bot] : httpRequest: Failure connecting to the service https://api.github.com/orgs/elastic/members/mergify[bot] : Code: 404Error: {"message":"User does not exist or is not a member of the organization","documentation_url":"https://docs.github.com/rest/reference/orgs#check-organization-membership-for-a-user"}

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport needs_team Indicates that the issue/PR needs a Team:* label
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants