-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix getProviderFromDomain function, move from integration test #28963
fix getProviderFromDomain function, move from integration test #28963
Conversation
This pull request does not have a backport label. Could you fix it @aspacca? 🙏
NOTE: |
This pull request is now in conflicts. Could you fix it? 🙏
|
Pinging @elastic/integrations (Team:Platforms) |
Co-authored-by: endorama <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I just added a comment to clarify the intention of the change but LGTM. Is my understanding that integration tests are not run, or I did not understand why they did not catch the bug 🤔
the test was added in the integration test file that has |
* fix getProviderFromDomain function, move from integration test * changelog * license * Update x-pack/filebeat/input/awss3/input.go Co-authored-by: endorama <[email protected]> Co-authored-by: endorama <[email protected]> (cherry picked from commit 3ffcee0)
…integration test (#28972) * fix getProviderFromDomain function, move from integration test (#28963) * fix getProviderFromDomain function, move from integration test * changelog * license * Update x-pack/filebeat/input/awss3/input.go Co-authored-by: endorama <[email protected]> Co-authored-by: endorama <[email protected]> (cherry picked from commit 3ffcee0) * fix changelog Co-authored-by: Andrea Spacca <[email protected]>
Bug
What does this PR do?
fix logic to discover provider from endpoint in
getProviderFromDomain
Why is it important?
#28234 introduced the possibility to use not AWS S3 bucket as input for filebeat.
A function was added to discover the provider when using custom endpoints
The logic was broken since the test were using the wrong input for the function.
We didn't spot during CR of the PR because the test for the function was added to integration test file, that has a build constraint that skip it from running during PR
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration filesCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.Author's Checklist
How to test this PR locally
Related issues
Use cases
Screenshots
Logs