libbeat/cmd/instance/metrics: fix error message #23413
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Upon failure to retrieve cgroup stats, the log message should say "error getting cgroup stats" and not "error getting group status".
axw
added
bug
Team:Services
|
Pinging @elastic/integrations-services (Team:Services) |
botelastic
bot
added
needs_team
1 task
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
💚 Flaky test reportTests succeeded. Expand to view the summary
Test stats 🧪
|
andresrc
approved these changes
Jan 11, 2021
1 task
axw
added a commit
to axw/beats
that referenced
this pull request
Jan 11, 2021
Upon failure to retrieve cgroup stats, the log message should say "error getting cgroup stats" and not "error getting group status". (cherry picked from commit 8e8bfc8)
axw
added a commit
to axw/beats
that referenced
this pull request
Jan 11, 2021
Upon failure to retrieve cgroup stats, the log message should say "error getting cgroup stats" and not "error getting group status". (cherry picked from commit 8e8bfc8)
1 task
axw
added a commit
that referenced
this pull request
Jan 13, 2021
axw
added a commit
that referenced
this pull request
Jan 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Upon failure to retrieve cgroup stats, the log
message should say "error getting cgroup stats"
and not "error getting group status".
Why is it important?
Because the invalid log message is confusing.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have made corresponding changes to the documentation- [ ] I have made corresponding change to the default configuration files- [ ] I have added tests that prove my fix is effective or that my feature works- [ ] I have added an entry inCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
N/A (trivial change)
Related issues
https://github.com/elastic/beats/pull/21113/files#r554442805