Update CONTRIBUTING.md (cherry-pick #2263 into 5.0) #2273
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@elastic/beats I figured it wouldn't hurt to cherry-pick this into 5.0. However, I'm not going to bother cherry-picking into earlier releases (unless you tell me to) because I figure most people will/should be looking at this file in master anyhow, right? |
| @@ -70,13 +67,13 @@ Packetbeat: | |||
| $ cd beats/packetbeat | |||
| $ make | |||
|
|
|||
| Some of the Beats might have extra development requirements, in which case a | |||
| CONTRIBUTING.md file is find in the Beat directory. | |||
| Some of the Beats might have extra development requirements, in which case you'll find a | |||
There was a problem hiding this comment.
As packetbeat is the only one with a local file, we should probably remove it in the future and here link to a general developer guide which then links to packetbeat dev guide. This again points in the direction that all dev guide should leave in on place (@urso ;-) ).
|
@dedemorton I think we don't need to backport these kind of changes to any of the branches as it is very rare that someone looks at a branch for contribution notes I would assume. |
Ofir-Lapid
added a commit
to build-security/beats
that referenced
this pull request
Nov 23, 2021
…ator-parser-#2273 Feature/adding tests evaluator parser elastic#2273
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.