-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Cherry-pick #21402 to 7.x: [Winlogbeat] Move winlogbeat javascript processor to libbeat #21429
Conversation
Pinging @elastic/siem (Team:SIEM) |
💔 Tests FailedExpand to view the summary
Build stats
Test stats 🧪
Test errorsExpand to view the tests failures
Steps errorsExpand to view the steps failures
Log outputExpand to view the last 100 lines of log output
|
run tests |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Double check CI after it finishes, seemed like a lot of red.
75dd706
to
50c226c
Compare
Ran pythonIntegTest by hand. Looks like the check for append processor having "allow_duplicates" isn't working in this branch. I'll investigate the error but will merge this since it isn't related.
|
Cherry-pick of PR #21402 to 7.x branch. Original message:
What does this PR do?
Renames winlogbeat javascript processor to windows and moves it to
libbeat. Processor can still be loaded as
winlogbeat
for backwardscompatibility.,
Why is it important?
Needed so Filebeat winlog input can have access to the winlogbeat
javascript processor.
Checklist
- [ ] I have commented my code, particularly in hard-to-understand areas- [ ] I have added an entry inCHANGELOG.next.asciidoc
orCHANGELOG-developer.next.asciidoc
.How to test this PR locally
go test in winlogbeat modules