-
Notifications
You must be signed in to change notification settings - Fork 4.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make elasticsearch/ccr metricset work for Stack Monitoring without xpack.enabled flag #21348
Merged
sayden
merged 12 commits into
elastic:feature-stack-monitoring-mb-ecs
from
sayden:feature/mb/elasticsearch/ccr_xpack_flag
Nov 20, 2020
Merged
Changes from 7 commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
f3588ed
Merge branch 'master' into feature-stack-monitoring-mb-ecs
sayden bb431af
Squash changes and fix conflicts
sayden e6f2efe
Add TestData test and data.json file
sayden 9434d99
Fix asciidoc
sayden 4d1eed2
Fix mapping issues
sayden ddd6b15
Remove commented field
sayden f5d34be
Use full response from Elasticsearch in / mock path and update the da…
sayden 4d2f9fa
Merge branch 'feature-stack-monitoring-mb-ecs' into feature/mb/elasti…
sayden 3d881b6
Fix lint in ccr_test.go
sayden f0cb525
Fix typo
sayden d4cd1c2
Fix typo in json file
sayden 227ef4a
Fix broken test
sayden File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
Large diffs are not rendered by default.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,39 +1,109 @@ | ||
| { | ||
| "@timestamp": "2017-10-12T08:05:34.853Z", | ||
| "agent": { | ||
| "hostname": "host.example.com", | ||
| "name": "host.example.com" | ||
| }, | ||
| "elasticsearch": { | ||
| "ccr": { | ||
| "auto_follow": { | ||
| "failed": { | ||
| "follow_indices": { | ||
| "count": 0 | ||
| }, | ||
| "remote_cluster_state_requests": { | ||
| "count": 0 | ||
| } | ||
| }, | ||
| "success": { | ||
| "follow_indices": { | ||
| "count": 1 | ||
| } | ||
| } | ||
| }, | ||
| "bytes_read": 32768, | ||
| "follower": { | ||
| "global_checkpoint": -1, | ||
| "index": "my_index_f", | ||
| "operations_written": 0, | ||
| "global_checkpoint": 768, | ||
| "index": "follower_index", | ||
| "max_seq_no": 896, | ||
| "operations": { | ||
| "read": { | ||
| "count": 896 | ||
| } | ||
| }, | ||
| "operations_written": 832, | ||
| "settings_version": 2, | ||
| "shard": { | ||
| "number": 0 | ||
| }, | ||
| "time_since_last_read": { | ||
| "ms": 42294 | ||
| "ms": 8 | ||
| } | ||
| }, | ||
| "leader": { | ||
| "index": "my_index", | ||
| "max_seq_no": -1 | ||
| "global_checkpoint": 1024, | ||
| "index": "leader_index", | ||
| "max_seq_no": 1536 | ||
| }, | ||
| "requests": { | ||
| "failed": { | ||
| "read": { | ||
| "count": 0 | ||
| }, | ||
| "write": { | ||
| "count": 0 | ||
| } | ||
| }, | ||
| "outstanding": { | ||
| "read": { | ||
| "count": 8 | ||
| }, | ||
| "write": { | ||
| "count": 2 | ||
| } | ||
| }, | ||
| "successful": { | ||
| "read": { | ||
| "count": 32 | ||
| }, | ||
| "write": { | ||
| "count": 16 | ||
| } | ||
| } | ||
| }, | ||
| "total_time": { | ||
| "read": { | ||
| "ms": 32768, | ||
| "remote_exec": { | ||
| "ms": 16384 | ||
| } | ||
| }, | ||
| "write": { | ||
| "ms": 16384 | ||
| } | ||
| }, | ||
| "write_buffer": { | ||
| "operation": { | ||
| "count": 64 | ||
| }, | ||
| "size": { | ||
| "bytes": 1536 | ||
| } | ||
| } | ||
| }, | ||
| "cluster": { | ||
| "id": "3LbUkLkURz--FR-YO0wLNA", | ||
| "name": "es1" | ||
| "id": "8l_zoGznQRmtoX9iSC-goA", | ||
| "name": "docker-cluster" | ||
| } | ||
| }, | ||
| "event": { | ||
| "dataset": "elasticsearch.ccr", | ||
| "duration": 115000, | ||
| "module": "elasticsearch" | ||
| }, | ||
| "metricset": { | ||
| "host": "127.0.0.1:9200", | ||
| "module": "elasticsearch", | ||
| "name": "ccr", | ||
| "rtt": 115 | ||
| "period": 10000 | ||
| }, | ||
| "service": { | ||
| "name": "elasticsearch" | ||
| "address": "127.0.0.1:49940", | ||
| "name": "elasticsearch", | ||
| "type": "elasticsearch" | ||
| } | ||
| } | ||
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@sayden Looks like this file got deleted. Any chance you could regenerate it? The other Stack Monitoring PRs have it so it would be good to have it in this PR too.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay. I have added a
TestDatafunction to work with mock input data and now we have adata.json🎉