Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cherry-pick #20088 to 7.x: [Ingest Manager] Fixed unzip on older windows #20108

Merged
merged 2 commits into from
Jul 27, 2020
Merged

Cherry-pick #20088 to 7.x: [Ingest Manager] Fixed unzip on older windows #20108

merged 2 commits into from
Jul 27, 2020

Conversation

ph
Copy link
Contributor

@ph ph commented Jul 21, 2020

Cherry-pick of PR #20088 to 7.x branch. Original message:

What does this PR do?

We used Expand_Archive function provided by powershell to unpack zip archives on windows. this is not available on PowerShell 4. Strategy is changed not to use powershell functionaliry but rather the approach taken with tars - walking and expanding the archive.

Why is it important?

Supporting windows 8 and server 2012

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas @ph
[Ingest Manager] Fixed unzip on older windows (#20088)
8bf7c63 
* unpacking using zip package

* changelog

* fmt

(cherry picked from commit ded2e99)
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Jul 21, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Jul 21, 2020
@botelastic
Copy link

botelastic bot commented Jul 21, 2020

This pull request doesn't have a Team:<team> label.

@ph ph requested a review from blakerouse July 21, 2020 18:27
@elasticmachine
Copy link
Collaborator

elasticmachine commented Jul 21, 2020 •
edited by jenkins-beats-ci bot
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

  • Build Cause: [Pull request #20108 updated]

  • Start Time: 2020-07-27T15:47:49.104+0000

  • Duration: 45 min 25 sec

michalpristas
michalpristas approved these changes Jul 22, 2020
View reviewed changes
Copy link
Contributor

@michalpristas michalpristas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@ph ph merged commit cbfbc43 into elastic:7.x Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michalpristas michalpristas michalpristas approved these changes

@blakerouse blakerouse Awaiting requested review from blakerouse

Assignees
No one assigned
Labels
backport [zube]: In Review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ph @elasticmachine @michalpristas