[Elastic Agent] Require --insecure on enroll for connection to Kibana #19900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
botelastic
bot
added
needs_team
blakerouse
force-pushed
the
agent-enroll-insecure
branch
from
686d98c to
534e371
Compare
|
Pinging @elastic/ingest-management (Team:Ingest Management) |
ph
approved these changes
Jul 14, 2020
There was a problem hiding this comment.
LGTM, tested locally.
Could we update the documentation in https://github.com/elastic/beats/blob/master/x-pack/elastic-agent/docs/elastic-agent-command-line.asciidoc for the added flags/changes?
| @@ -69,6 +71,9 @@ func (e *EnrollCmdOption) kibanaConfig() (*kibana.Config, error) { | |||
| if err != nil { | |||
| return nil, err | |||
| } | |||
| if cfg.Protocol == kibana.ProtocolHTTP && !e.Insecure { | |||
| return nil, fmt.Errorf("connection to Kibana is insecure, strongly recommended to use a secure connection (override with --insecure)") | |||
2 tasks
blakerouse
added a commit
to blakerouse/beats
that referenced
this pull request
Jul 15, 2020
…elastic#19900) * Add insecure option to enroll. * Set TLS to not verify on --insecure. * Run mage fmt * Add changelog. * Update enroll for certificate-authorities and ca-sha256. * Update changelog. * Update docstring. (cherry picked from commit 55c4534)
blakerouse
added a commit
that referenced
this pull request
Jul 15, 2020
…ll for connection to Kibana (#19910) * [Elastic Agent] Require --insecure on enroll for connection to Kibana (#19900) * Add insecure option to enroll. * Set TLS to not verify on --insecure. * Run mage fmt * Add changelog. * Update enroll for certificate-authorities and ca-sha256. * Update changelog. * Update docstring. (cherry picked from commit 55c4534) * Fix enroll_cmd_test.go.
mdelapenya
added a commit
to mdelapenya/e2e-testing
that referenced
this pull request
Jul 15, 2020
melchiormoulin
pushed a commit
to melchiormoulin/beats
that referenced
this pull request
Oct 14, 2020
…elastic#19900) * Add insecure option to enroll. * Set TLS to not verify on --insecure. * Run mage fmt * Add changelog. * Update enroll for certificate-authorities and ca-sha256. * Update changelog. * Update docstring.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Adds a
--insecureoption toenrollcommand to allow enrollment to Kibana with SSL that is insecure. Adds the requirement of using--insecurewhen using the HTTP protocol.This also includes a rename of
--ca_sha256to--ca-sha256and--certificate_authoritiesto--certificate-authorities. From a command line standpoint I think its best to standardize on-versus a mix of-and_.Why is it important?
To strongly require users to use secure connection to Kibana.
Checklist
[ ] I have commented my code, particularly in hard-to-understand areas[ ] I have made corresponding changes to the documentation[ ] I have made corresponding change to the default configuration files[ ] I have added tests that prove my fix is effective or that my feature worksCHANGELOG.next.asciidocorCHANGELOG-developer.next.asciidoc.How to test this PR locally
Related issues