Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Ingest Manager] Remove fleet admin from setup script #18611

Merged
merged 2 commits into from
May 18, 2020
Merged

[Ingest Manager] Remove fleet admin from setup script #18611

merged 2 commits into from
May 18, 2020

Conversation

michalpristas
Copy link
Contributor

@michalpristas michalpristas commented May 18, 2020 •
edited
Loading

What does this PR do?

As fleet removed admin username and password from fleet setup it's not needed to send this anymore

Why is it important?

To successfully setup env

Checklist

  • My code follows the style guidelines of this project
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • I have made corresponding change to the default configuration files
  • I have added tests that prove my fix is effective or that my feature works
  • I have added an entry in CHANGELOG.next.asciidoc or CHANGELOG-developer.next.asciidoc.

@michalpristas michalpristas added bug review needs_backport PR is waiting to be backported to other branches. Team:Ingest Management Ingest Management:beta1 Group issues for ingest management beta1 labels May 18, 2020
@michalpristas michalpristas requested review from ruflin and nchaulet May 18, 2020 10:29
@michalpristas michalpristas self-assigned this May 18, 2020
@elasticmachine
Copy link
Collaborator

Pinging @elastic/ingest-management (Team:Ingest Management)

@botelastic botelastic bot added needs_team Indicates that the issue/PR needs a Team:* label and removed needs_team Indicates that the issue/PR needs a Team:* label labels May 18, 2020
@elasticmachine
Copy link
Collaborator

elasticmachine commented May 18, 2020 •
edited
Loading

💚 Build Succeeded

Pipeline View Test View Changes Artifacts preview

Expand to view the summary

Build stats

Test stats 🧪

Test Results
Failed 0
Passed 9211
Skipped 1542
Total 10753

@michalpristas michalpristas mentioned this pull request May 18, 2020
Closed
ruflin
ruflin approved these changes May 18, 2020
View reviewed changes
Copy link
Collaborator

@ruflin ruflin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@michalpristas michalpristas merged commit a0788d7 into elastic:master May 18, 2020
michalpristas added a commit to michalpristas/beats that referenced this pull request May 18, 2020
@michalpristas
[Ingest Manager] Remove fleet admin from setup script (elastic#18611)
3398e2f 
* removed unnecessary fleet admin

* change
@michalpristas michalpristas mentioned this pull request May 18, 2020
Merged
6 tasks
michalpristas added a commit that referenced this pull request May 19, 2020
@michalpristas
[Ingest Manager] Remove fleet admin from setup script (#18611) (#18615)
c6753f2 
[Ingest Manager] Remove fleet admin from setup script (#18611) (#18615)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ruflin ruflin ruflin approved these changes

@nchaulet nchaulet nchaulet approved these changes

Assignees

@michalpristas michalpristas

Labels
bug Ingest Management:beta1 Group issues for ingest management beta1 needs_backport PR is waiting to be backported to other branches. review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@michalpristas @elasticmachine @ruflin @nchaulet