[7.x] Allow delete and index actions with a document ID (#12606) #18308

ycombinator · 2020-05-06T12:56:34Z

Backports the following commits to 7.x:

Allow delete and index actions with a document ID (Allow delete and index actions with a document ID #12606)

* Add `op_type` meta key for delete and index operations with a document ID. * Add note on why `obj` can be nil. * Refactor and extract consts. * Don't include metadata prefix in key. * Stop appending `nil` else it ends up in the body. * Error when trying to delete with no _id. * Remove incorrect detail in comment. * Add unit test for new op_type meta key. * No longer required. * Return error to caller. * Fail event if op_type is no string. * Use consts in error. * Replace assert with require. * Fail instead of panic. * Change missed assert calls to require. * Simplify GetMetaStringValue. * Ignore err as key may not exist.

elasticmachine · 2020-05-06T12:56:40Z

Pinging @elastic/integrations-services (Team:Services)

elasticmachine · 2020-05-06T15:01:22Z

💔 Build Failed

Expand to view the summary

Build stats

Build Cause: [Pull request [7.x] Allow delete and index actions with a document ID (#12606) #18308 opened]
Start Time: 2020-05-06T12:57:23.301+0000
Duration: 124 min 44 sec (7423622)
Commit: 37575c5

Test stats 🧪

Test	Results
Failed	0
Passed	5804
Skipped	889
Total	6693

Steps errors

Expand to view the steps failures

Name: Report to Codecov
- Description: curl -sSLo codecov https://codecov.io/bash for i in auditbeat filebeat heartbeat libbeat metricbeat packetbeat winlogbeat journalbeat do FILE="${i}/build/coverage/full.cov" if [ -f "${FILE}" ]; then bash codecov -f "${FILE}" fi done
- Result: FAILURE
- Duration: 2 min 23 sec<
- Start Time: 2020-05-06T14:05:14.728+0000

Log output

Expand to view the last 100 lines of log output

[2020-05-06T15:00:24.659Z] 		at org.jenkinsci.plugins.workflow.steps.durable_task.DurableTaskStep$Execution$1.run(DurableTaskStep.java:504)
[2020-05-06T15:00:24.659Z] 		at jenkins.security.ImpersonatingScheduledExecutorService$1.run(ImpersonatingScheduledExecutorService.java:58)
[2020-05-06T15:00:24.659Z] 		at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[2020-05-06T15:00:24.659Z] 		at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[2020-05-06T15:00:24.659Z] 		at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.access$201(ScheduledThreadPoolExecutor.java:180)
[2020-05-06T15:00:24.659Z] 		at java.util.concurrent.ScheduledThreadPoolExecutor$ScheduledFutureTask.run(ScheduledThreadPoolExecutor.java:293)
[2020-05-06T15:00:24.659Z] 		at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[2020-05-06T15:00:24.659Z] 		at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[2020-05-06T15:00:24.659Z] jenkins.util.io.CompositeIOException: Unable to delete 'C:\Users\jenkins\workspace\Beats_beats-beats-mbp_PR-18308\src\github.com\elastic\beats\auditbeat@tmp\durable-271697d2'. Tried 3 times (of a maximum of 3) waiting 0.1 sec between attempts.
[2020-05-06T15:00:24.659Z] 	at jenkins.util.io.PathRemover.forceRemoveRecursive(PathRemover.java:99)
[2020-05-06T15:00:24.659Z] 	at hudson.Util.deleteRecursive(Util.java:295)
[2020-05-06T15:00:24.659Z] 	at hudson.FilePath$DeleteRecursive.invoke(FilePath.java:1271)
[2020-05-06T15:00:24.659Z] 	at hudson.FilePath$DeleteRecursive.invoke(FilePath.java:1267)
[2020-05-06T15:00:24.659Z] 	at hudson.FilePath$FileCallableWrapper.call(FilePath.java:3073)
[2020-05-06T15:00:24.659Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:212)
[2020-05-06T15:00:24.659Z] 	at hudson.remoting.UserRequest.perform(UserRequest.java:54)
[2020-05-06T15:00:24.659Z] 	at hudson.remoting.Request$2.run(Request.java:369)
[2020-05-06T15:00:24.659Z] 	at hudson.remoting.InterceptingExecutorService$1.call(InterceptingExecutorService.java:72)
[2020-05-06T15:00:24.659Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[2020-05-06T15:00:24.659Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[2020-05-06T15:00:24.659Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[2020-05-06T15:00:24.659Z] 	at hudson.remoting.Engine$1.lambda$newThread$0(Engine.java:93)
[2020-05-06T15:00:24.659Z] 	at java.lang.Thread.run(Thread.java:748)
[2020-05-06T15:00:29.770Z] Recording test results
[2020-05-06T15:00:30.590Z] Error when executing cleanup post condition:
[2020-05-06T15:00:30.590Z] org.jenkinsci.plugins.workflow.steps.FlowInterruptedException
[2020-05-06T15:00:30.590Z] 	at org.jenkinsci.plugins.workflow.cps.CpsBodyExecution.cancel(CpsBodyExecution.java:253)
[2020-05-06T15:00:30.590Z] 	at org.jenkinsci.plugins.workflow.steps.BodyExecution.cancel(BodyExecution.java:76)
[2020-05-06T15:00:30.590Z] 	at org.jenkinsci.plugins.workflow.cps.steps.ParallelStepExecution.stop(ParallelStepExecution.java:67)
[2020-05-06T15:00:30.590Z] 	at org.jenkinsci.plugins.workflow.cps.CpsThread.stop(CpsThread.java:306)
[2020-05-06T15:00:30.590Z] 	at org.jenkinsci.plugins.workflow.cps.CpsBodyExecution$2.onSuccess(CpsBodyExecution.java:271)
[2020-05-06T15:00:30.590Z] 	at org.jenkinsci.plugins.workflow.cps.CpsBodyExecution$2.onSuccess(CpsBodyExecution.java:258)
[2020-05-06T15:00:30.590Z] 	at org.jenkinsci.plugins.workflow.cps.CpsFlowExecution$4$1.run(CpsFlowExecution.java:907)
[2020-05-06T15:00:30.590Z] 	at org.jenkinsci.plugins.workflow.cps.CpsVmExecutorService$1.run(CpsVmExecutorService.java:38)
[2020-05-06T15:00:30.590Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[2020-05-06T15:00:30.590Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[2020-05-06T15:00:30.590Z] 	at hudson.remoting.SingleLaneExecutorService$1.run(SingleLaneExecutorService.java:131)
[2020-05-06T15:00:30.590Z] 	at jenkins.util.ContextResettingExecutorService$1.run(ContextResettingExecutorService.java:28)
[2020-05-06T15:00:30.590Z] 	at jenkins.security.ImpersonatingExecutorService$1.run(ImpersonatingExecutorService.java:59)
[2020-05-06T15:00:30.590Z] 	at java.util.concurrent.Executors$RunnableAdapter.call(Executors.java:511)
[2020-05-06T15:00:30.590Z] 	at java.util.concurrent.FutureTask.run(FutureTask.java:266)
[2020-05-06T15:00:30.590Z] 	at java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1149)
[2020-05-06T15:00:30.590Z] 	at java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:624)
[2020-05-06T15:00:30.590Z] 	at java.lang.Thread.run(Thread.java:748)
[2020-05-06T15:00:30.590Z] 
[2020-05-06T15:00:31.341Z] Failed in branch Metricbeat x-pack
[2020-05-06T15:00:31.605Z] Stage "Libbeat stress-tests" skipped due to earlier failure(s)
[2020-05-06T15:00:31.638Z] Stage "Generators Metricbeat Mac OS X" skipped due to earlier failure(s)
[2020-05-06T15:00:32.607Z] Failed in branch Libbeat
[2020-05-06T15:00:32.660Z] Stage "Generators Beat Mac OS X" skipped due to earlier failure(s)
[2020-05-06T15:00:33.497Z] Failed in branch Generators
[2020-05-06T15:00:36.853Z] None of the test reports contained any result
[2020-05-06T15:00:38.690Z] Stashed 0 file(s)
[2020-05-06T15:00:38.766Z] Archiving artifacts
[2020-05-06T15:00:42.497Z] Failed in branch Auditbeat oss
[2020-05-06T15:00:45.028Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats
[2020-05-06T15:00:45.978Z] + find . -type f -name TEST*.xml -path */build/* -delete
[2020-05-06T15:00:46.135Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Lint
[2020-05-06T15:00:46.594Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Winlogbeat-oss
[2020-05-06T15:00:47.165Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Elastic-Agent-x-pack
[2020-05-06T15:00:47.670Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Dockerlogbeat
[2020-05-06T15:00:48.122Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Elastic-Agent-x-pack-Windows
[2020-05-06T15:00:48.486Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Journalbeat-oss
[2020-05-06T15:00:48.855Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Functionbeat-x-pack
[2020-05-06T15:00:49.224Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Generators-Metricbeat-Linux
[2020-05-06T15:00:49.817Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Metricbeat-crosscompile
[2020-05-06T15:00:50.194Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Metricbeat-OSS-Unit-tests
[2020-05-06T15:00:50.685Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Heartbeat-oss
[2020-05-06T15:00:51.058Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Winlogbeat-Windows-x-pack
[2020-05-06T15:00:51.479Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Filebeat-Windows
[2020-05-06T15:00:51.917Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Auditbeat-x-pack
[2020-05-06T15:00:52.353Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Libbeat-x-pack
[2020-05-06T15:00:52.721Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Auditbeat-Linux
[2020-05-06T15:00:53.113Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Metricbeat-Windows
[2020-05-06T15:00:53.512Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Packetbeat-oss
[2020-05-06T15:00:54.068Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Winlogbeat-Windows
[2020-05-06T15:00:54.471Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Filebeat-x-pack
[2020-05-06T15:00:54.888Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Auditbeat-crosscompile
[2020-05-06T15:00:55.896Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Filebeat-oss
[2020-05-06T15:00:56.314Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Generators-Beat-Linux
[2020-05-06T15:00:56.651Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Heartbeat-Windows
[2020-05-06T15:00:57.021Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Metricbeat-Python-integration-tests
[2020-05-06T15:00:57.478Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Functionbeat-Windows
[2020-05-06T15:00:57.975Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Libbeat-oss
[2020-05-06T15:00:58.361Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Metricbeat-OSS-Integration-tests
[2020-05-06T15:00:58.777Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Metricbeat-x-pack
[2020-05-06T15:00:59.208Z] Running in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308/src/github.com/elastic/beats/Auditbeat-Windows
[2020-05-06T15:01:00.368Z] + cat
[2020-05-06T15:01:00.368Z] + /usr/local/bin/runbld ./runbld-script
[2020-05-06T15:01:00.368Z] Picked up JAVA_TOOL_OPTIONS: -Dfile.encoding=UTF8
[2020-05-06T15:01:03.597Z] Body did not finish within grace period; terminating with extreme prejudice
[2020-05-06T15:01:03.834Z] ERROR: runbld post build action failed.
[2020-05-06T15:01:03.834Z] Timeout has been exceeded
[2020-05-06T15:01:04.763Z] Running on Jenkins in /var/lib/jenkins/workspace/Beats_beats-beats-mbp_PR-18308
[2020-05-06T15:01:05.297Z] [INFO] getVaultSecret: Getting secrets
[2020-05-06T15:01:05.513Z] Masking supported pattern matches of $VAULT_ADDR or $VAULT_ROLE_ID or $VAULT_SECRET_ID
[2020-05-06T15:01:07.218Z] + chmod 755 generate-build-data.sh
[2020-05-06T15:01:07.218Z] + ./generate-build-data.sh https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18308/ https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18308/runs/1 ABORTED 7423622
[2020-05-06T15:01:08.129Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18308/runs/1/steps/?limit=10000 -o steps-info.json
[2020-05-06T15:01:10.613Z] INFO: curl https://beats-ci.elastic.co/blue/rest/organizations/jenkins/pipelines/Beats/beats-beats-mbp/PR-18308/runs/1/tests/?status=FAILED -o tests-errors.json

botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label May 6, 2020

ycombinator added [zube]: In Review backport Team:Services (Deprecated) Label for the former Integrations-Services team labels May 6, 2020

zube bot added [zube]: Inbox and removed [zube]: In Review labels May 6, 2020

kvch approved these changes May 6, 2020

View reviewed changes

ycombinator merged commit 896b1d0 into elastic:7.x May 6, 2020

ycombinator deleted the backport/7.x/pr-12606 branch May 6, 2020 21:11

zube bot added [zube]: Done and removed [zube]: Inbox labels May 6, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[7.x] Allow delete and index actions with a document ID (#12606) #18308

[7.x] Allow delete and index actions with a document ID (#12606) #18308

ycombinator commented May 6, 2020

elasticmachine commented May 6, 2020

elasticmachine commented May 6, 2020

Build stats

Test stats 🧪

[7.x] Allow delete and index actions with a document ID (#12606) #18308

[7.x] Allow delete and index actions with a document ID (#12606) #18308

Conversation

ycombinator commented May 6, 2020

elasticmachine commented May 6, 2020

elasticmachine commented May 6, 2020

💔 Build Failed

Build stats

Test stats 🧪

Steps errors

Log output