Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix cisco-ftd test case for new behavior of lowercase processor #17095

Merged
merged 1 commit into from
Mar 18, 2020

Conversation

adriansr
Copy link
Contributor

@adriansr adriansr commented Mar 18, 2020

What does this PR do?

Updates the golden files for Filebeat's cisco/ftd fileset to adapt to the new behavior of ingest node's lowercase processor after elastic/elasticsearch#53343

Why is it important?

So that integration tests pass when run against an Elasticsearch that contains the changes linked above.

Logs

Error fixed by this:

test_xpack_modules.XPackTest.test_fileset_file_065_cisco

AssertionError: The following expected object doesn't match:
 Diff:
{'iterable_item_added': {"root['network.application'][0]": 'advanced packaging tool', "root['network.application'][1]": 'ubuntu'}, 'iterable_item_removed': {"root['network.application'][1]": 'Ubuntu', "root['network.application'][0]": 'Advanced Packaging Tool'}}, full object:
[...]

After elastic/elasticsearch#53343, ingest node's lowercase processor
will lowercase values in arrays. This is causing the integration tests
to fail.
@adriansr adriansr added review needs_backport PR is waiting to be backported to other branches. labels Mar 18, 2020
@adriansr adriansr changed the title Fix cisco-ftd test case for new lowercase processor Fix cisco-ftd test case for new behavior of lowercase processor Mar 18, 2020
@adriansr adriansr merged commit 0731f45 into elastic:master Mar 18, 2020
adriansr added a commit to adriansr/beats that referenced this pull request Mar 19, 2020
After elastic/elasticsearch#53343, ingest node's lowercase processor
will lowercase values in arrays. This is causing the integration tests
to fail.

(cherry picked from commit 0731f45)
@adriansr adriansr added v7.7.0 and removed needs_backport PR is waiting to be backported to other branches. labels Mar 19, 2020
adriansr added a commit that referenced this pull request Mar 19, 2020
After elastic/elasticsearch#53343, ingest node's lowercase processor
will lowercase values in arrays. This is causing the integration tests
to fail.

(cherry picked from commit 0731f45)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants